Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port PR #48989 to master #56691

Merged

Conversation

nicholasmhughes
Copy link
Collaborator

What does this PR do?

Port PR #48989 to master

What issues does this PR fix or reference?

PR #48989

Commits signed with GPG?

Yes

@nicholasmhughes nicholasmhughes requested a review from a team as a code owner April 18, 2020 01:35
@ghost ghost requested review from cmcmarrow and removed request for a team April 18, 2020 01:35
cmcmarrow
cmcmarrow previously approved these changes Apr 20, 2020
Copy link
Contributor

@cmcmarrow cmcmarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Ch3LL Ch3LL added this to PR needs merge to master in PRs to port to master via automation Apr 22, 2020
@nicholasmhughes
Copy link
Collaborator Author

re-run ubuntu1604-py3-m2crypto

@nicholasmhughes
Copy link
Collaborator Author

@cmcmarrow can you re-up your review?
@dwoz tests fixed

@cmcmarrow
Copy link
Contributor

@nicholasmhughes sorry for the delay. Had sometime off due to the 4th.

@cmcmarrow
Copy link
Contributor

Your PR is good to be Merged. Thanks for helping port PRs to Master!

@dwoz dwoz merged commit 1f70709 into saltstack:master Jul 28, 2020
26 checks passed
PRs to port to master automation moved this from PR needs merge to master to PR merged Jul 28, 2020
@sagetherage sagetherage added the Magnesium Mg release after Na prior to Al label Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Magnesium Mg release after Na prior to Al master-port
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants