-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port PR #48989 to master #56691
Merged
dwoz
merged 7 commits into
saltstack:master
from
nicholasmhughes:port-insert-match-to-blockreplace
Jul 28, 2020
Merged
Port PR #48989 to master #56691
dwoz
merged 7 commits into
saltstack:master
from
nicholasmhughes:port-insert-match-to-blockreplace
Jul 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcmarrow
previously approved these changes
Apr 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
re-run ubuntu1604-py3-m2crypto |
@cmcmarrow can you re-up your review? |
@nicholasmhughes sorry for the delay. Had sometime off due to the 4th. |
cmcmarrow
approved these changes
Jul 7, 2020
Your PR is good to be Merged. Thanks for helping port PRs to Master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Port PR #48989 to master
What issues does this PR fix or reference?
PR #48989
Commits signed with GPG?
Yes