Port #51033 to master #56704
Merged
Port #51033 to master #56704
+96
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
DmitryKuzmenko
added
the
needs-testcase
Contributor
Author
|
I've added a testcase and also made a slight tweak. This was limited to Python 3 only because it looks like the original author of this PR was unaware of how to force |
garethgreenaway
added
master-port
and removed
needs-testcase
terminalmage
force-pushed
the
bp-51033
branch
2 times, most recently
from
7839171 to
d472f1a
Compare
The issue with different behavior between Python 2 and 3 was fixed in ffdae27 around the same time the original PR was opened. There is no need to restrict this code exclusively to Python 3.
dwoz
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #51033