Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port #51033 to master #56704

Merged
merged 5 commits into from
May 7, 2020
Merged

Port #51033 to master #56704

merged 5 commits into from
May 7, 2020

Conversation

terminalmage
Copy link
Contributor

See #51033

@terminalmage terminalmage requested a review from a team as a code owner April 18, 2020 18:56
@ghost ghost requested review from DmitryKuzmenko and removed request for a team April 18, 2020 18:56
@DmitryKuzmenko DmitryKuzmenko added the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Apr 20, 2020
@terminalmage
Copy link
Contributor Author

I've added a testcase and also made a slight tweak. This was limited to Python 3 only because it looks like the original author of this PR was unaware of how to force salt.utils.vt to write a str type irrespective of which version of Python (something that was fixed by @garethgreenaway in ffdae27 around the same time the original PR was merged).

@garethgreenaway garethgreenaway added master-port and removed Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases labels Apr 21, 2020
@terminalmage terminalmage force-pushed the bp-51033 branch 2 times, most recently from 7839171 to d472f1a Compare May 3, 2020 02:21
jp-harvey and others added 5 commits May 2, 2020 21:21
The issue with different behavior between Python 2 and 3 was fixed in
ffdae27 around the same time the
original PR was opened. There is no need to restrict this code
exclusively to Python 3.
@dwoz dwoz merged commit b49f137 into saltstack:master May 7, 2020
@sagetherage sagetherage added the ZRelease-Sodium retired label label May 18, 2020
@sagetherage sagetherage added this to Done in Sodium May 18, 2020
@terminalmage terminalmage deleted the bp-51033 branch February 12, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Sodium
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants