Conversation
ghost
requested review from
Contributor
|
@terminalmage thanks for the port! Are you also planning to add tests for this? |
Contributor
Author
|
No, I'm just trying to get the ball rolling on these ports. I don't really understand how this cloud provider works, but I can read a diff. |
waynew
added
the
needs-testcase
Contributor
Author
|
I decided to take a crack at adding some test cases. |
Contributor
Author
|
The |
sagetherage
removed
the
needs-testcase
terminalmage
force-pushed
the
bp-50334
branch
2 times, most recently
from
63cfc05 to
b4f8ac4
Compare
dwoz
approved these changes
May 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #50334