Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port changes from #48704 #56782

Merged
merged 3 commits into from
Apr 23, 2020
Merged

Port changes from #48704 #56782

merged 3 commits into from
Apr 23, 2020

Conversation

dwoz
Copy link
Contributor

@dwoz dwoz commented Apr 21, 2020 •
edited
Loading

Master port of #48704

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

  • [ x] Docs
  • Changelog
  • [x ] Tests written/updated

Commits signed with GPG?

Yes

@dwoz dwoz requested a review from a team as a code owner April 21, 2020 17:49
@ghost ghost requested review from DmitryKuzmenko and removed request for a team April 21, 2020 17:49
@dwoz dwoz force-pushed the pr/48704 branch 2 times, most recently from d4fed7c to dc8f450 Compare April 21, 2020 18:03
@dwoz
Copy link
Contributor Author

dwoz commented Apr 22, 2020

osx test failure looks legit

@dwoz dwoz merged commit 4b94e1a into saltstack:master Apr 23, 2020
@sagetherage sagetherage added the ZRelease-Sodium retired label label May 18, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garethgreenaway garethgreenaway garethgreenaway approved these changes

@Akm0d Akm0d Akm0d approved these changes

@DmitryKuzmenko DmitryKuzmenko Awaiting requested review from DmitryKuzmenko

Assignees
No one assigned
Labels
master-port ZRelease-Sodium retired label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dwoz @garethgreenaway @Akm0d @sagetherage