Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master port 50264 #56831

Merged
merged 2 commits into from Apr 22, 2020
Merged

Master port 50264 #56831

merged 2 commits into from Apr 22, 2020

Conversation

joechainz
Copy link

#50264

What does this PR do?

when #22370 was introduced it
actually removed functionality, as sometimes it desirable to onfail if
ALL of the listed requisites are failure. This adds back an 'onfail_all'
form that allows for this behavior (it would make more sense to have
onfail default to OR logic, but that would break backcompat, so we add
a new form instead).

What issues does this PR fix or reference?

#47015

I was in the neighborhood so also fixed #49382 and #49120

Tests written?

Yes

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

mattp- and others added 2 commits April 22, 2020 11:01
when saltstack#22370 was introduced it
actually removed functionality, as sometimes it desirable to onfail if
ALL of the listed requisites are failure. This adds back an 'onfail_all'
form that allows for this behavior (it would make more sense to have
onfail default to OR logic, but that would break backcompat, so we add
a new form instead).
@joechainz joechainz requested a review from a team as a code owner April 22, 2020 17:26
@ghost ghost requested review from Akm0d and removed request for a team April 22, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Sodium
  
Done
Development

Successfully merging this pull request may close these issues.

onfail requisite always triggers when combined with other requisites
4 participants