[master] Port #50053 to master - #56856
Merged
Merged
Conversation
in multimaster hot-hot environments, all events are streamed to all masters for a given minion. this introduces the problem of a reactor being executed on each hot master, regardless of if the reaction is idempotent or not. This patch introduces a simple is_leader bool that can be controlled via the reactor runner (or emitting the equivalent event to toggle) whether a reactor in hot-standby mode should be reacting to events coming into the bus. The feature itself is disconnected from multimaster, and is by default True, so it should be inert in most saltstack installs. Tests forthcoming in following commit
the event based api that was earlier implemented to allow for controlling the reactor engine had no means of auth, any minion could send in events to influence it. adding the master key ensures those events come from the valid local master only.
Akm0d
approved these changes
Apr 22, 2020
dwoz
approved these changes
Apr 23, 2020
Contributor
|
Has anyone tried this? |
Contributor
|
@max-arnold just tried on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port #50053 to master