Work around upstream bug in Jinja2 indent filter - #56860
Merged
Merged
Conversation
terminalmage
force-pushed
the
issue56833
branch
from
April 23, 2020 12:50
af8af59 to
381e9d1
Compare
This conditionally uses a port of the upstream version of the filter with the fix in place. The minion will only get this filter if it has Jinja < 2.11 installed.
Contributor
|
re-run full all |
dwoz
approved these changes
Apr 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This conditionally uses a port of the upstream version of the filter with the fix in place. The minion will only get this filter if it has Jinja < 2.11 installed.
What issues does this PR fix or reference?
Fixes #56833
Previous Behavior
Piping content that has gone through the
yamlfilter (or any other one which returns aMarkupobject) into theindentfilter would result in some characters (<,>,",&, and maybe others) being encoded (example in the linked issue).New Behavior
This content is properly handled by Jinja.
Merge requirements satisfied?
Commits signed with GPG?
No