Port #50168 to master #56881
Merged
Port #50168 to master #56881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
dwoz
requested changes
Apr 24, 2020
DmitryKuzmenko
force-pushed
the
master-port-50168
branch
from
8a95fee
to
1f4e946
Compare
|
@dwoz I've updated the code accordingly to your request. |
Allow to refresh pillar synchronously This PR adds the optional ability to run saltutil.refresh_pillar Allow to refresh pillar synchronously, saying saltutil.refresh_pillar async=False. I tried to follow the explanatory comment from @gtmanfred and I believe that this works, still I am not sure about the mentioned use of the _gather_pillar() method. I am happy to rework the PR if something is missing. [DKuzmenko] I've slightly reworked it to resolve conflicts with functionality added to master by DWoz in saltstack#54942. Co-authored-by: Dmitry Kuzmenko <dmitry.kuzmenko@dsr-corporation.com>
Removed 'notify' argument. Removed superfluous event send. Minor updates
DmitryKuzmenko
force-pushed
the
master-port-50168
branch
from
1f4e946
to
c33d9a0
Compare
dwoz
approved these changes
May 12, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #50168 to master
I've tried to rework it to resolve crossing with functionality added to master by DWoz in #54942.
Original comment: