Port #49697 and #49926 to master #56893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
DmitryKuzmenko
force-pushed
the
master-port-49697-49926
branch
2 times, most recently
from
8ac894e to
d6bdd9b
Compare
Fix set_static_all, always display requestmode and refactor _change_state. Display requestmode even if service is offline. This will keep parity between older and newer nilrt distro. Split the logic of _change_state function for older and newer disto. Fix set_static_all. If there are no nameservers specified, we shouldn't set any property for nameservers configuration to the service.
Configure network interfaces without cable & add tests. On NG we use connman as a network manager which consider a service, an interface connected with a cable. The only way to set-up an interface without a cable is through config files. This works also for services because before we start the connamn daemon, we create a config file, /var/lib/connman/interfaces.config with DHCP settings for each interface.
DmitryKuzmenko
force-pushed
the
master-port-49697-49926
branch
from
d6bdd9b to
7733879
Compare
dwoz
previously approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #49697 and #49926 to master.
Dismiss #56863