Allow openstack driver to attach multiple networks#56961
Merged
dwoz merged 10 commits intosaltstack:masterfrom May 20, 2020
Merged
Allow openstack driver to attach multiple networks#56961dwoz merged 10 commits intosaltstack:masterfrom
dwoz merged 10 commits intosaltstack:masterfrom
Conversation
ghost
requested review from
Contributor
Author
|
(Apologies for not writing any tests or docs. I've submitted this as it was my workaround which got things to work for me. Feel free to use as a starting point to do it properly!!) |
Ch3LL
added
the
needs-testcase
It looks like this one got missed when this was introduced. Everywhere else within openstack.py uses this pattern. Also added some tests for this function to ensure that it does the expected thing.
Added tests for Mark Hyde.
waynew
removed
help-wanted
dwoz
approved these changes
May 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It allows the openstack
networkkwarg to be either a list or a dict, where previously it only allowed a dict. This allows multiple networks to be attached to a device during build using salt-cloud.What issues does this PR fix or reference?
Fixes: #56960
Previous Behaviour
Can only attach 1 network or the defaults if not specified. (Or get a complaint about not being a dict)
New Behaviour
Can attach multiple networks
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.