Changes for BUG opened: 56995

[bfdacosta]

What does this PR do?

Fix mediatype_create and mediatype_get usage since new API 4.4.

• Added a apiinfo_version call to check the API version when
  dealing with mediatype_create and get.
• Changed the attribute called from "description" to "name",
  when API version is greater or equal to 4.4. changed both
  mediatype_create and mediatype_get.

What issues does this PR fix or reference?

Fixes #56995

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

[DmitryKuzmenko]

@bfdacosta thank you for contribution! Could you please also write a regression tests for your changes?

[bfdacosta]

DmitryKuzmenko, greetings! Can you point me out a regression test that is needed. Any example code for that ? Thanks !

[mchugh19]

@bfdacosta there are unit tests for the zabbix module in salt/tests/unit/modules/test_zabbix.py. You could create a test which mocks a version response of 4.3 and validate that the json is generated in the expected format. This could then be copied and modified for the 4.4 version and expected response.

[DmitryKuzmenko]

Thank you @mchugh19 .
@bfdacosta do you need any advice on that?

[bfdacosta]

I will produce the test.
The problem is not the answer, its how the call to the API is done. Thats is the difference between versions. I will lookup for the test.

[DmitryKuzmenko]

@bfdacosta I think you can mock it with stubs just checking the logic goes in a proper ways with different stubbed version values. Also you can add links to the corresponding documentation to the stubs to make it easily understandable. I don't think we have to test this particular change with a real zabbix servers.

[bfdacosta]

Test added to the code.

[bfdacosta]

@DmitryKuzmenko let me know if anything else still needed for merge! Thanks!

[DmitryKuzmenko]

@bfdacosta yes, could you please update your branch and re-run pre-commit on it? There're some issues

05:38:19  Drop six usage and Py2 support...........................................Failed
05:38:19  - hook id: pyupgrade
05:38:19  - exit code: 1
05:38:19  - files were modified by this hook
05:38:19  
05:38:19  Rewriting salt/modules/zabbix.py
05:38:19  Rewriting tests/unit/modules/test_zabbix.py
05:38:19  
05:38:20  isort....................................................................Passed
05:38:25  black....................................................................Failed
05:38:25  - hook id: black
05:38:25  - files were modified by this hook
05:38:25  
05:38:25  reformatted /var/jenkins/workspace/pr-pre-commit_PR-56996/salt/modules/zabbix.py
05:38:25  All done! ✨ 🍰 ✨
05:38:25  1 file reformatted, 1 file left unchanged.

[bfdacosta]

@DmitryKuzmenko Greetings!!! All problems solved. Thanks!