Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support macOS defaulting to spawn as the default multiprocessing method #57028

Merged

Conversation

s0undt3ch
Copy link
Collaborator

@s0undt3ch s0undt3ch commented May 1, 2020

What does this PR do?

Support macOS defaulting to spawn as the default multiprocessing method

What issues does this PR fix or reference?

We were previously forcing macOS to use fork instead of the the default spawn method, we fix that in this PR
Fixes #55847
Fixes #57742
Refs #61045

Previous Behavior

We used the "fork" method for macOS

New Behavior

We use the default spawn method for macOS

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

  • Docs
  • Changelog
  • Tests written/updated - The whole test suite under macOS

Commits signed with GPG?

Yes

@s0undt3ch s0undt3ch force-pushed the features/multiprocessing-method branch 9 times, most recently from 538c315 to afb60db Compare May 8, 2020 12:09
@s0undt3ch s0undt3ch marked this pull request as ready for review May 9, 2020 10:34
@s0undt3ch s0undt3ch requested a review from a team as a code owner May 9, 2020 10:34
@ghost ghost requested review from cmcmarrow and removed request for a team May 9, 2020 10:34
@dwoz dwoz added Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases has-failing-test labels May 12, 2020
@s0undt3ch s0undt3ch force-pushed the features/multiprocessing-method branch from afb60db to 45b5f1e Compare May 18, 2020 10:47
@s0undt3ch s0undt3ch added ZRelease-Sodium retired label and removed Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases has-failing-test labels May 18, 2020
@sagetherage sagetherage added this to In progress in Sodium via automation May 18, 2020
@s0undt3ch s0undt3ch force-pushed the features/multiprocessing-method branch from 05a9e92 to 7aff97d Compare May 19, 2020 09:54
@sagetherage
Copy link
Contributor

fixes #55847

@s0undt3ch s0undt3ch force-pushed the features/multiprocessing-method branch from 7aff97d to 489658c Compare May 21, 2020 14:49
@weswhet
Copy link
Contributor

weswhet commented May 21, 2020

on behalf of the macOS folks thank you, thank you, thank you!

@weswhet
Copy link
Contributor

weswhet commented May 21, 2020

this looks great. I know you mentioned that this isn't likely to hit Sodium but it would be awesome if it could.

@sagetherage sagetherage removed the ZRelease-Sodium retired label label May 22, 2020
@sagetherage sagetherage removed this from In progress in Sodium May 22, 2020
@sagetherage sagetherage added the Magnesium Mg release after Na prior to Al label May 22, 2020
@sagetherage sagetherage removed the Magnesium Mg release after Na prior to Al label Jun 1, 2020
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
…to avoid ``NameError`` issues

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
…ues.

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
…onal tests.

Fixes saltstack#60819

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Fixes saltstack#57742

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Fixes saltstack#55847

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch s0undt3ch force-pushed the features/multiprocessing-method branch from f17f6f0 to 0c67fb6 Compare May 5, 2022 16:38
@s0undt3ch
Copy link
Collaborator Author

re-run full all

@garethgreenaway garethgreenaway merged commit 1dc10a5 into saltstack:master May 20, 2022
MacOS automation moved this from In progress to Done May 20, 2022
@s0undt3ch
Copy link
Collaborator Author

🎆

@s0undt3ch s0undt3ch deleted the features/multiprocessing-method branch May 20, 2022 19:14
@natewalck
Copy link

You are all heroes <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-failing-test MacOS pertains to the OS of fruit Phosphorus v3005.0 Release code name and version python3 regarding Python 3 support severity-critical top severity, seen by most users, serious issues
Projects
MacOS
  
Done
8 participants