Merged
Conversation
alexey-zhukovin
added
needs-testcase
ghost
requested review from
I had considered doing something with regex like `\d+(\.\d+)*`, then I realized that there are other valid version strings that perhaps do not contain numerics separated by `.`, so this option is a bit more flexible as far as what versions nginx can return. The major weakness here is that it does require nginx to return the version on the first line, and to use a `/` separator before the version itself. One potential alternative would be to use the regex `r'(\w+\.(\w+\.?)*)'` and get groups()[0] from that, however that *would* require at least a decimal point. There's a number of other options that one could use here, however, we're currently simply banking on nginx always returning the actual version prefixed with a forward slash.
waynew
removed
needs-testcase
Ch3LL
approved these changes
May 21, 2021
twangboy
approved these changes
May 26, 2021
krionbsd
approved these changes
May 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Port #49964 to master