Add arpcheck to RH8 IP#57114
Merged
Merged
Conversation
In saltstack#20602 we added the ability to change ARPCHECK in network settings. This was missing and later added in RH7, but was missing from RH8, since RH8 support was added before we updated the RH7 support. This fixes saltstack#57047
ghost
requested review from
Contributor
|
See also #55359 |
Contributor
Author
|
FWIW the reporter on #57047 reports that copying rh7 to rh8 works fine. Granted that's a sample size of 1, so there may be other holes we want to be sure we're aware of! |
cmcmarrow
approved these changes
May 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #20602 we added the ability to change ARPCHECK in network settings.
This was missing and later added in RH7, but was missing from RH8, since
RH8 support was added before we updated the RH7 support.
This fixes #57047
Previous Behavior
Missing the ARPCHECK seems to trigger some strange behavior (see #57047)
New Behavior
The behavior should not be triggered
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
DocsTests written/updatedCommits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.