Skip to content

Add arpcheck to RH8 IP #57114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2020
Merged

Add arpcheck to RH8 IP #57114

merged 1 commit into from
May 8, 2020

Conversation

waynew
Copy link
Contributor

@waynew waynew commented May 6, 2020

In #20602 we added the ability to change ARPCHECK in network settings.
This was missing and later added in RH7, but was missing from RH8, since
RH8 support was added before we updated the RH7 support.

This fixes #57047

Previous Behavior

Missing the ARPCHECK seems to trigger some strange behavior (see #57047)

New Behavior

The behavior should not be triggered

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

  • Docs
  • Changelog
  • Tests written/updated

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

In saltstack#20602 we added the ability to change ARPCHECK in network settings.
This was missing and later added in RH7, but was missing from RH8, since
RH8 support was added before we updated the RH7 support.

This fixes saltstack#57047
@waynew waynew requested a review from a team as a code owner May 6, 2020 19:39
@ghost ghost requested review from Akm0d and removed request for a team May 6, 2020 19:39
@waynew waynew added the ZRelease-Sodium retired label label May 6, 2020
@bryceml
Copy link
Contributor

bryceml commented May 6, 2020

See also #55359

@waynew
Copy link
Contributor Author

waynew commented May 6, 2020

FWIW the reporter on #57047 reports that copying rh7 to rh8 works fine. Granted that's a sample size of 1, so there may be other holes we want to be sure we're aware of!

@dwoz dwoz merged commit 24cec5b into saltstack:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZRelease-Sodium retired label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

network.managed fails unexpectedly on el8
4 participants