Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pdbedit module for Debian version #57141

Merged
merged 3 commits into from
May 8, 2020
Merged

Update pdbedit module for Debian version #57141

merged 3 commits into from
May 8, 2020

Conversation

sjorge
Copy link
Contributor

@sjorge sjorge commented May 7, 2020

What does this PR do?

This fixes 2 issues with the version matching:

  • Version 4.5.0 is new enough according to this comment.

What issues does this PR fix or reference?

Fixes:

Previous Behavior

Regex did not deal with junk behind the version number, e.g. debian adds branding there.

New Behavior

Regex ignores the stuff after the version, relaxes version requirements to 4.5.0.

Merge requirements satisfied?>

  • Docs
  • Changelog
  • Tests written/updated

Commits signed with GPG?

No

sjorge added 2 commits May 7, 2020 21:16
Debian seems to prepend `-Debian` behind the version, we should test those too.
Also lower the requirement to 4.5.0 as apparently that version is new enough according to
#55185 (comment)
@sjorge sjorge requested a review from a team as a code owner May 7, 2020 19:20
@ghost ghost requested review from dwoz and removed request for a team May 7, 2020 19:20
@sjorge
Copy link
Contributor Author

sjorge commented May 7, 2020

Not sure I did the changelog thing correctly.

@dwoz dwoz merged commit 0f27c9f into saltstack:master May 8, 2020
@sjorge sjorge deleted the pdbedit_debian branch May 8, 2020 16:42
@sjorge
Copy link
Contributor Author

sjorge commented May 8, 2020

Thanks for merging,good to be back to the older turn over times! <3

@sagetherage sagetherage added the ZRelease-Sodium retired label label May 18, 2020
@sagetherage sagetherage added this to Done in Sodium May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZRelease-Sodium retired label
Projects
No open projects
Sodium
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants