Update pdbedit module for Debian version#57141
Merged
dwoz merged 3 commits intosaltstack:masterfrom May 8, 2020
sjorge:pdbedit_debian
Merged
Update pdbedit module for Debian version#57141dwoz merged 3 commits intosaltstack:masterfrom sjorge:pdbedit_debian
dwoz merged 3 commits intosaltstack:masterfrom
sjorge:pdbedit_debian
Conversation
Debian seems to prepend `-Debian` behind the version, we should test those too. Also lower the requirement to 4.5.0 as apparently that version is new enough according to #55185 (comment)
ghost
requested review from
This was referenced May 7, 2020
Contributor
Author
|
Not sure I did the changelog thing correctly. |
dwoz
approved these changes
May 8, 2020
Contributor
Author
|
Thanks for merging,good to be back to the older turn over times! <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes 2 issues with the version matching:
What issues does this PR fix or reference?
Fixes:
Previous Behavior
Regex did not deal with junk behind the version number, e.g. debian adds branding there.
New Behavior
Regex ignores the stuff after the version, relaxes version requirements to 4.5.0.
Merge requirements satisfied?>
Commits signed with GPG?
No