Merged
Conversation
ghost
requested review from
s0undt3ch
previously approved these changes
May 11, 2020
Contributor
Author
|
re-run full all |
Refactor SyncWrapper so that it uses an alternate ioloop and runs it in a thread. This is needed for torando 5.0 and greater on python 3 where asyncio's event loop is the default. The asyncio default loop can only have on loop running at a time in any given thread. So, the old SyncWrapper doesn't work because it tires to run multiple ioloops in the main execution thread.
Contributor
Author
|
re-run full ubuntu2004 |
Contributor
Author
|
re-run full macosxmojave |
Akm0d
approved these changes
May 21, 2020
garethgreenaway
approved these changes
May 21, 2020
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor SyncWrapper so that it uses an alternate ioloop and runs it in
a thread. This is needed for torando 5.0 and greater on python 3 where
asyncio's event loop is the default. The asyncio default loop can only
have on loop running at a time in any given thread. So, the old
SyncWrapper doesn't work because it tires to run multiple ioloops in the
main execution thread.
Merge requirements satisfied?
Commits signed with GPG?
Yes