Add proxy to log rotation and update syndic rotation for SUSE #57354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Needs 3 reviewers |
s0undt3ch
previously approved these changes
May 18, 2020
dwoz
added
the
Needs-Testcase
Akm0d
previously approved these changes
May 18, 2020
DmitryKuzmenko
approved these changes
May 19, 2020
|
@dwoz this is a simple fix and needs 3 reviewers, mocking a log rotation does not compute. |
dwoz
removed
the
Needs-Testcase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds proxy logs to log rotation
What issues does this PR fix or reference?
Fixes: #57353
Previous Behavior
Proxy logs could fill available disk space
New Behavior
Proxy logs are now part of log rotation
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.