Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sodium deprecations #57370

Merged
merged 13 commits into from May 22, 2020
Merged

Sodium deprecations #57370

merged 13 commits into from May 22, 2020

Conversation

waynew
Copy link
Contributor

@waynew waynew commented May 19, 2020

What does this PR do?

Removes all the places that were marked with 'warn_until` and Sodium

What issues does this PR fix or reference?

Several - all referenced in the commit messages

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@waynew waynew requested a review from as a code owner May 19, 2020
@ghost ghost requested review from DmitryKuzmenko and removed request for May 19, 2020
s0undt3ch
s0undt3ch previously approved these changes May 19, 2020
or template_hash.startswith("file://")
)
if not isinstance(_managed, (list, tuple)) and isinstance(
_managed, six.string_types
Copy link
Member

@s0undt3ch s0undt3ch May 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could take the time and stop using six.string_types in favor or str on places where code is updated.

DmitryKuzmenko
DmitryKuzmenko previously approved these changes May 19, 2020
@DmitryKuzmenko
Copy link
Contributor

@DmitryKuzmenko DmitryKuzmenko commented May 19, 2020

The tests failures are related BTW.

@waynew waynew dismissed stale reviews from DmitryKuzmenko and s0undt3ch via cf5adbd May 20, 2020
@sagetherage sagetherage added the ZRelease-Sodium label May 20, 2020
@sagetherage sagetherage added this to In progress in Sodium via automation May 20, 2020
@@ -1,6 +0,0 @@
=====================
Copy link
Contributor

@DmitryKuzmenko DmitryKuzmenko May 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I can see the keystone module was deprecated and have to be removed but I don't see removal of the module in this PR.

Copy link
Contributor Author

@waynew waynew May 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's been punted to the next release - the state was not deprecated, and hasn't been re-written to take advantage of the keystoneng module. Looks like I need to put the docs back, though 😝

waynew added 11 commits May 21, 2020
Closes saltstack#57362

These arguments are no longer useful, since we no longer support using
NAPALM native templates.
It was deprecated and slated for removal in Sodium. Closes saltstack#57363
Closes saltstack#57366

Parameter has been renamed to `refresh`
Closes saltstack#57367

sdecode and sdecode_if_string functionalities have both been moved to
decode.
Closes saltstack#57368

- removed obsolete .destroy methods from zeromq channels
- removed winexe support from salt.utils.cloud
- removed obsolete override_name from
  salt.utils.context.NamespacedDictWrapper
- removed obsolete `show_ipv4` parameter from salt.utils.minions
- removed impacket support from salt.utils.smb
- removed obsolete salt.transport.Channel, and fixed test.
@waynew waynew added this to In progress in [TEST] Wayne's Work May 21, 2020
@waynew
Copy link
Contributor Author

@waynew waynew commented May 21, 2020

re-run full all

@dwoz
Copy link
Contributor

@dwoz dwoz commented May 22, 2020

re-run ubuntu

@dwoz dwoz merged commit ee181c9 into saltstack:master May 22, 2020
26 of 27 checks passed
Sodium automation moved this from In progress to Done May 22, 2020
[TEST] Wayne's Work automation moved this from In progress to Done May 22, 2020
@max-arnold max-arnold mentioned this pull request Jul 12, 2020
1 task
@max-arnold
Copy link
Contributor

@max-arnold max-arnold commented Jul 12, 2020

The old module.run syntax deprecation note was still pointing to 3001. Fixed in 5494619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZRelease-Sodium
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants