Merged
Conversation
ghost
requested review from
s0undt3ch
previously approved these changes
May 19, 2020
salt/modules/napalm_network.py
Outdated
Contributor
There was a problem hiding this comment.
We could take the time and stop using six.string_types in favor or str on places where code is updated.
DmitryKuzmenko
previously approved these changes
May 19, 2020
Contributor
|
The tests failures are related BTW. |
waynew
force-pushed
the
sodium-deprecations
branch
from
cf5adbd to
bee3442
Compare
Contributor
There was a problem hiding this comment.
As I can see the keystone module was deprecated and have to be removed but I don't see removal of the module in this PR.
Contributor
Author
There was a problem hiding this comment.
That's been punted to the next release - the state was not deprecated, and hasn't been re-written to take advantage of the keystoneng module. Looks like I need to put the docs back, though 😝
Closes saltstack#57362 These arguments are no longer useful, since we no longer support using NAPALM native templates.
It was deprecated and slated for removal in Sodium. Closes saltstack#57363
Closes saltstack#57366 Parameter has been renamed to `refresh`
Closes saltstack#57367 sdecode and sdecode_if_string functionalities have both been moved to decode.
Closes saltstack#57368 - removed obsolete .destroy methods from zeromq channels - removed winexe support from salt.utils.cloud - removed obsolete override_name from salt.utils.context.NamespacedDictWrapper - removed obsolete `show_ipv4` parameter from salt.utils.minions - removed impacket support from salt.utils.smb - removed obsolete salt.transport.Channel, and fixed test.
waynew
force-pushed
the
sodium-deprecations
branch
from
837302f to
90eee56
Compare
Contributor
Author
|
re-run full all |
Contributor
|
re-run ubuntu |
1 task
Contributor
|
The old |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes all the places that were marked with 'warn_until` and Sodium
What issues does this PR fix or reference?
Several - all referenced in the commit messages
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes