Repair template_vars functionality and allow for dest keyword in rpc on Junos #57389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
@vnitinv Can you take a look at this too and leave comments |
vnitinv
reviewed
May 20, 2020
s0undt3ch
previously approved these changes
May 20, 2020
twangboy
previously approved these changes
May 20, 2020
dwoz
previously approved these changes
May 20, 2020
dwoz
previously approved these changes
May 20, 2020
|
Re-did changes after an updated merge of master branch was done out of order for these changes |
|
I am discussing this with @dmurphy18 , please do not merge it. |
|
Discussed issue with Nitin and new changes made to resolve concerns, ready for review and merge |
twangboy
approved these changes
May 21, 2020
dwoz
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Repairs template_vars functionality on Junos and compensates for dest keyword in rpc commands
What issues does this PR fix or reference?
Fixes: #57388
Previous Behavior
load and certain rpc's on Junos would fail, see #57388
New Behavior
load and rpc commands with dest parameters now function correctly, see #57388
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.