use hashlib instead of shelling out to generate a server_id#57415
Merged
dwoz merged 4 commits intosaltstack:masterfrom May 22, 2020
Merged
use hashlib instead of shelling out to generate a server_id#57415dwoz merged 4 commits intosaltstack:masterfrom
dwoz merged 4 commits intosaltstack:masterfrom
Conversation
ghost
requested review from
cmcmarrow
previously approved these changes
May 21, 2020
dwoz
added
the
needs-testcase
Contributor
Author
|
This change would alter |
dhiltonp
force-pushed
the
server_id_hashlib
branch
from
4f79dc8 to
7e8f6f4
Compare
dwoz
removed
the
needs-testcase
dwoz
approved these changes
May 22, 2020
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Streamlines get_server_id, generating the hash inside the current process.
Commits signed with GPG?
Yes/No