Skip to content

enable_fqdns_grains default to false on Windows#57576

Merged
dwoz merged 6 commits intosaltstack:masterfrom
twangboy:fqdns_grains
Jun 9, 2020
Merged

enable_fqdns_grains default to false on Windows#57576
dwoz merged 6 commits intosaltstack:masterfrom
twangboy:fqdns_grains

Conversation

@twangboy
Copy link
Contributor

@twangboy twangboy commented Jun 5, 2020

What does this PR do?

Sets enable_fqdns_grains to False by default on Windows. Brings the minion config option into the docs and the minion config file. enable_fqdns_grains was introduced here: #55581

What issues does this PR fix or reference?

Fixes: #57529

Previous Behavior

Salt commands take an additional 5 seconds due to IP resolution to FQDN timeout on Windows.

New Behavior

Salt is peppy...

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@twangboy twangboy requested a review from a team as a code owner June 5, 2020 23:44
@ghost ghost requested review from DmitryKuzmenko and removed request for a team June 5, 2020 23:44
@marbx
Copy link
Contributor

marbx commented Jun 6, 2020

Setting enable_fqdns_grains to False does not fix #57529, because

s0undt3ch
s0undt3ch previously approved these changes Jun 6, 2020
Copy link
Contributor

@s0undt3ch s0undt3ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but this change is noteworthy of a changelog entry.

@twangboy
Copy link
Contributor Author

twangboy commented Jun 8, 2020

@s0undt3ch Done

s0undt3ch
s0undt3ch previously approved these changes Jun 8, 2020
DmitryKuzmenko
DmitryKuzmenko previously approved these changes Jun 8, 2020
Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some changelog... changes.

@twangboy twangboy dismissed stale reviews from DmitryKuzmenko and s0undt3ch via a411beb June 8, 2020 20:09
DmitryKuzmenko
DmitryKuzmenko previously approved these changes Jun 8, 2020
Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo fix, then 👍

@twangboy twangboy requested a review from DmitryKuzmenko June 8, 2020 21:15
@dwoz dwoz merged commit bfde74f into saltstack:master Jun 9, 2020
@damon-atkins
Copy link
Contributor

Interesting to known what the performance is of the nslookup and

$ComputerIPAddress = ‘10.10.10.10’
[System.Net.Dns]::GetHostEntry($ComputerIPAddress).HostName
$ComputerIPAddress = '172.217.6.174'
[System.Net.Dns]::GetHostEntry($ComputerIPAddress).HostName
c:\salt\bin\python -c "import socket;print(socket.gethostbyaddr('10.10.10.10')[0])"
 # 5 seconds not found
c:\salt\bin\python -c "import socket,time;t=time.time();print(socket.gethostbyaddr('172.217.6.174')[0],time.time()-t)"
dfw25s17-in-f14.1e100.net 0.07795596122741699
# 0.08 seconds found

If people do not have reverse DNS records it will be slower, than people who do have reverse DNS.
There should be no performance difference between Windows and Linux.

@damon-atkins
Copy link
Contributor

@twangboy twangboy deleted the fqdns_grains branch March 23, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ZRelease-Sodium retired label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [RC1 Sodium] esxi/vsphere busy poll (100% CPU) for 8 seconds on Windows

7 participants