enable_fqdns_grains default to false on Windows#57576
Merged
dwoz merged 6 commits intosaltstack:masterfrom Jun 9, 2020
Merged
Conversation
Contributor
|
Setting
|
s0undt3ch
previously approved these changes
Jun 6, 2020
Contributor
s0undt3ch
left a comment
There was a problem hiding this comment.
Approved, but this change is noteworthy of a changelog entry.
Contributor
Author
|
@s0undt3ch Done |
s0undt3ch
previously approved these changes
Jun 8, 2020
DmitryKuzmenko
previously approved these changes
Jun 8, 2020
waynew
suggested changes
Jun 8, 2020
Contributor
waynew
left a comment
There was a problem hiding this comment.
Just some changelog... changes.
DmitryKuzmenko
previously approved these changes
Jun 8, 2020
s0undt3ch
approved these changes
Jun 8, 2020
Contributor
|
Interesting to known what the performance is of the nslookup and If people do not have reverse DNS records it will be slower, than people who do have reverse DNS. |
Contributor
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sets
enable_fqdns_grainstoFalseby default on Windows. Brings the minion config option into the docs and the minion config file.enable_fqdns_grainswas introduced here: #55581What issues does this PR fix or reference?
Fixes: #57529
Previous Behavior
Salt commands take an additional 5 seconds due to IP resolution to FQDN timeout on Windows.
New Behavior
Salt is peppy...
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.