Import vsphere only on esxi hosts#57579
Merged
Merged
Conversation
ghost
requested review from
twangboy
previously approved these changes
Jun 8, 2020
twangboy
added
v3001.1
bryceml
reviewed
Jun 8, 2020
Contributor
|
@bryceml I read that like 10 times and couldn't see it... |
twangboy
approved these changes
Jun 8, 2020
bryceml
approved these changes
Jun 8, 2020
Contributor
|
FYI this caused a bug in Salt 3001, see #57811. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
import vsphereonly on esxi hosts.What issues does this PR fix?
#57529
Current Behavior
The esxi grains attempt to load vsphere before testing if the minion is an esxi hosts.
On Windows, this attempt wastes 3/4 of a
test.pingcommand (13 of 16 profiled seconds) by busy polling (100%CPU).Merge requirements satisfied?