Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filterwarning overide previously defined filters ISSUE:57582 #57598

Merged
merged 3 commits into from Jul 29, 2020
Merged

Filterwarning overide previously defined filters ISSUE:57582 #57598

merged 3 commits into from Jul 29, 2020

Conversation

jynolen
Copy link
Contributor

@jynolen jynolen commented Jun 9, 2020

What does this PR do?

This PR add append parameters to filterwarnings to avoid overidding previously defined filters

What issues does this PR fix or reference?

Fixes: #57582

Commits signed with GPG?

No

@jynolen jynolen requested a review from a team as a code owner June 9, 2020 11:02
@ghost ghost requested review from xeacott and removed request for a team June 9, 2020 11:02
@dwoz dwoz added Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases has-failing-test labels Jun 16, 2020
@sagetherage sagetherage requested review from DmitryKuzmenko and removed request for xeacott July 22, 2020 23:16
@sagetherage sagetherage added Bug broken, incorrect, or confusing behavior severity-low 4th level, cosemtic problems, work around exists labels Jul 22, 2020
@DmitryKuzmenko
Copy link
Contributor

@s0undt3ch could you please take a look at this?

Copy link
Member

@s0undt3ch s0undt3ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! A reasonable change.

@dwoz dwoz merged commit 24d503a into saltstack:master Jul 29, 2020
26 checks passed
@sagetherage sagetherage added the Magnesium Mg release after Na prior to Al label Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior Magnesium Mg release after Na prior to Al Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases severity-low 4th level, cosemtic problems, work around exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Salt override previously defined filterwarnings
5 participants