Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #57602 #57603

Merged
merged 4 commits into from
Jul 29, 2020
Merged

Fix #57602 #57603

merged 4 commits into from
Jul 29, 2020

Conversation

gizahNL
Copy link
Contributor

@gizahNL gizahNL commented Jun 9, 2020

What does this PR do?

Adds "display controller" to gpu_classes, enabling Intel GPU's using that classname to be found.

What issues does this PR fix or reference?

Fixes: #57602

Commits signed with GPG?

No

Fixes saltstack/salt saltstack#57602
@gizahNL gizahNL requested a review from a team as a code owner June 9, 2020 15:09
@ghost ghost requested review from waynew and removed request for a team June 9, 2020 15:09
@sagetherage sagetherage added Bug broken, incorrect, or confusing behavior Magnesium Mg release after Na prior to Al severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around labels Jun 15, 2020
waynew
waynew previously approved these changes Jun 15, 2020
Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gizahNL thanks for the PR!

s0undt3ch
s0undt3ch previously approved these changes Jun 16, 2020
@gizahNL
Copy link
Contributor Author

gizahNL commented Jun 16, 2020

@s0undt3ch you assigned me, I'm assuming to rebase; I did, and all checks passed :)
@waynew no need to thank for the PR, these changes are trivial ;)

@dwoz dwoz added the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Jun 16, 2020
@garethgreenaway garethgreenaway dismissed stale reviews from s0undt3ch and waynew via 1ae10c1 July 22, 2020 18:59
@garethgreenaway garethgreenaway removed the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Jul 22, 2020
@dwoz dwoz merged commit bc566c1 into saltstack:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior Magnesium Mg release after Na prior to Al severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Intel GPU not found in GPU grain
6 participants