Added strict argument to sdb.get - #57630
Merged
Merged
Conversation
waynew
previously approved these changes
Jun 15, 2020
Contributor
Author
waynew
approved these changes
Aug 20, 2020
waynew
left a comment
waynew
left a comment
Contributor
There was a problem hiding this comment.
I think this looks good. Though, looking at this, urllib.parse.urlparse would probably do a lot better here at simplifying/making explicit this code 😝
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a bool
strictargument to sdb.get module. If set totTruesdb.get will raise an exception if sdb uri is not correct. By default, it'sFalseto preserve old, weird behavior.What issues does this PR fix or reference?
Fixes: #39163
Merge requirements satisfied?
Commits signed with GPG?
Yes