Skip to content

Added strict argument to sdb.get #57630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 30, 2020
Merged

Added strict argument to sdb.get #57630

merged 3 commits into from
Sep 30, 2020

Conversation

Oloremo
Copy link
Contributor

@Oloremo Oloremo commented Jun 10, 2020 •
edited by waynew
Loading

What does this PR do?

Adds a bool strict argument to sdb.get module. If set tot True sdb.get will raise an exception if sdb uri is not correct. By default, it's False to preserve old, weird behavior.

What issues does this PR fix or reference?

Fixes: #39163

Merge requirements satisfied?

Commits signed with GPG?

Yes

@Oloremo Oloremo requested a review from a team as a code owner June 10, 2020 22:25
@ghost ghost requested review from waynew and removed request for a team June 10, 2020 22:25
waynew
waynew previously approved these changes Jun 15, 2020
View reviewed changes
@Oloremo
Copy link
Contributor Author

Oloremo commented Aug 20, 2020

@waynew @dwoz Tests are green now.

waynew
waynew approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. Though, looking at this, urllib.parse.urlparse would probably do a lot better here at simplifying/making explicit this code 😝

@cassandrafaris cassandrafaris added the Magnesium Mg release after Na prior to Al label Sep 23, 2020
@dwoz dwoz merged commit 6436a3e into saltstack:master Sep 30, 2020
@oliver-dungey oliver-dungey mentioned this pull request May 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynew waynew waynew approved these changes

Assignees
No one assigned
Labels
Magnesium Mg release after Na prior to Al
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vault SDB always returns the query URL for salt and salt-call. Salt-run executes properly.
4 participants
@Oloremo @waynew @dwoz @cassandrafaris