-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grain to list LVM volumes implement issue 57629 #57631
Add grain to list LVM volumes implement issue 57629 #57631
Conversation
@piterpunk thank you for contribution! Could you please cover your changes with tests? |
Hi Dmitry, tests added. I hope they are Ok. The tests for Linux and AIX are not the same because in AIX the LVM is part of base system, so it's always installed and with at least one volume group created. |
@piterpunk thank you! I've restarted macos x mojave tests the failure looked not related to your changes. |
@DmitryKuzmenko , seeing the console logs, the failure at MacOSX seems to be while setting up the environment, it didn't even began to run the tests. |
@piterpunk Everything passed. Thank you for your work! |
- LVM is an important information about a Linux machine. Usually Linux servers have most or all their disk filesystems using a logical volume as mountpoint. - This initial support implements a grain called "lvm" which returns a dictionary with the volume groups, each one with a list of their logical volumes inside: VolumeGroup00: - LogicalVolume00 - LogicalVolume01 - ... - LogicalVolumeNN VolumeGroup01: ... VolumeGroupNN: - LogicalVolume00 - LogicalVolume01 - ... - LogicalVolumeNN
- Added tests/unit/grains/test_lvm.py file - Tests covers _linux_lvm and _aix_lvm
aae0adf
to
7c5ea47
Compare
@DmitryKuzmenko , I did some changes to pass the new pre-commit tests, removing the usage of six and Py2 support. |
…Implement-Issue-57629
@piterpunk thank you! |
…Implement-Issue-57629
…Implement-Issue-57629
Tests are passing now (again). |
@DmitryKuzmenko , it's a lottery. Most tests fails by timeout, no available space, or error cloning the repository. I don't know if and how I can re-run only the failed tests, so my alternative is to merge from master until all tests passed. |
What does this PR do?
This initial support implements a grain called "lvm" which returns a dictionary with the volume groups, each one with a list of their logical volumes inside.
LVM is an important information about a Linux machine. Usually Linux servers have most or all their disk filesystems using a logical volume as mountpoint.
What issues does this PR fix or reference?
Implements and resolves #57629
New Behavior
To have a grain with the list of LVM volumes:
Merge requirements satisfied?
salt-runtests-20200610192428.log
Commits signed with GPG?
No