Improve macOS service naming support#57646
Merged
dwoz merged 9 commits intoSep 30, 2020
Merged
Conversation
…r the module converts over to the macOS naming convention of com.saltstack.salt.master
ghost
requested review from
19 tasks
Contributor
Author
|
Test failure isn't related to this PR. |
Contributor
Author
|
re-run ci/py3/ubuntu1604 |
Contributor
Author
|
re-run ubuntu1604 |
noelmcloughlin
previously approved these changes
Jun 13, 2020
Contributor
noelmcloughlin
left a comment
noelmcloughlin
left a comment
There was a problem hiding this comment.
LGTM. We need to get MacOS added to CI sometime soon.
DmitryKuzmenko
previously approved these changes
Jun 17, 2020
Contributor
|
@weswhet thank you for contribution! I'm good with this but since I'm not very familiar to MacOS specifics I want also @garethgreenaway to review this. |
garethgreenaway
previously approved these changes
Jun 17, 2020
Contributor
Author
|
Thanks @DmitryKuzmenko @garethgreenaway! |
Contributor
|
@weswhet No worries. Can we get a changelog file with the changes documented? |
weswhet
dismissed stale reviews from garethgreenaway, DmitryKuzmenko, and noelmcloughlin
via
bd23d48
Contributor
Author
|
@garethgreenaway thanks! Added the changelog for this fix. |
s0undt3ch
previously approved these changes
Jul 7, 2020
sagetherage
added
Magnesium
garethgreenaway
previously approved these changes
Sep 21, 2020
Contributor
Author
|
another all green one for ya @garethgreenaway 💚 |
garethgreenaway
approved these changes
Sep 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes it so if you specify a service on macOS by the naming convention similar to that of other platforms like
salt-minionit will convert it over to its proper namecom.saltstack.salt.minion. It will do the same forsalt-master,salt-api,salt-syndic.What issues does this PR fix or reference?
Fixes:
I've seen multi times where people mention that documentation mentions restarting a service by running
salt * service.restart salt-minionthey do this on macOS not knowing that the naming convention is different. This will automatically handle it for them.Helps support the Formula PR here.
Previous Behavior
macOS would fail with
Service not found: salt-masterNew Behavior
macOS will now know which service to look for and perform the correct action.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.