Allow resize in lvm.lv present state implement #57659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 12, 2020 16:11
- One of the advantages of LVM is the dynamic resizing of the logical volumes. While the module lvm already have an lvm.lvresize, there is no way to determine in a state to change a logical volume to a desired size. - This commit changes state lvm.lv_present to check if parameters size or extents are the same of the existing logical volume and, if not, calls lvm.lvresize to change it. - Also, added a test to check if parameters size *and* extents are present in the state and return an error. You can't specify both at the same time.
Now it tests for three situations: - Do Nothing: new size = old size - Resize: new size > old size - Return Error: new size < old size
ghost
requested review from
|
re-run centos8-py3 ubuntu1804-py3 |
|
re-run ubuntu1804-py3 |
|
@dwoz looks like failing tests were just flaky |
dwoz
approved these changes
Jul 29, 2020
piterpunk
deleted the
allow-resize-in-lvm.lv_present-state_Implement-Issue-55265
branch
|
Which release is required for this PR #57659 to be available? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If the size specified in a lvm.lv_present state is different than the logical volume actual size, the logical volume will be increased to the new specified size.
What issues does this PR fix or reference?
Fixes: #55265
Previous Behavior
Changing the parameter "size" in a lvm.lv_present state for an existent logical volume have no effect.
New Behavior
If you change "size" or "extents" parameter for an existent volume now it will be increased to the new value.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
salt-runtests-20200612191751.log
Commits signed with GPG?
No