libvirt events engine: constant fixes - #57747
Merged
Merged
Conversation
garethgreenaway
previously approved these changes
Jun 26, 2020
Contributor
Author
|
@garethgreenaway any merge time frame for that PR not that code freeze ended? |
Contributor
|
@cbosdo We're working through some failing tests before starting to merge PRs, hopefully this week. |
sagetherage
added
bug
Contributor
Author
|
Updated on latest master |
The libvirt constants for pool and nodedev events need tweaking since they don't match the rule used to autogenerate them. Fixes these warnings at the engine start. Skipping "pool/lifecycle" events: libvirt too old Skipping "pool/refresh" events: libvirt too old Skipping "nodedev/lifecycle" events: libvirt too old Skipping "nodedev/update" events: libvirt too old
cbosdo
force-pushed
the
libvirt-engine-fixes
branch
from
July 31, 2020 07:07
860951c to
732f0a6
Compare
Contributor
Author
|
Rebased on master and updated the six and py2 code. |
Contributor
Author
|
@dwoz could you merge this PR? it's a rather simple fix + the py2/six automated code cleanup. |
Akm0d
approved these changes
Jul 31, 2020
s0undt3ch
approved these changes
Jul 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The libvirt constants for pool and nodedev events need tweaking since
they don't match the rule used to autogenerate them.
What issues does this PR fix or reference?
Fixes: #57746
Previous Behavior
Storage pool and node device events were not reported as Salt events
New Behavior
Storage pool and node device events are reported as Salt events
Merge requirements satisfied?
Commits signed with GPG?
Yes