Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libvirt events engine: constant fixes #57747

Merged
merged 2 commits into from Jul 31, 2020

Conversation

cbosdo
Copy link
Collaborator

@cbosdo cbosdo commented Jun 22, 2020

What does this PR do?

The libvirt constants for pool and nodedev events need tweaking since
they don't match the rule used to autogenerate them.

What issues does this PR fix or reference?

Fixes: #57746

Previous Behavior

Storage pool and node device events were not reported as Salt events

New Behavior

Storage pool and node device events are reported as Salt events

Merge requirements satisfied?

Commits signed with GPG?

Yes

@cbosdo cbosdo requested a review from a team as a code owner June 22, 2020 10:10
@ghost ghost requested review from garethgreenaway and removed request for a team June 22, 2020 10:10
garethgreenaway
garethgreenaway previously approved these changes Jun 26, 2020
@cbosdo
Copy link
Collaborator Author

cbosdo commented Jul 10, 2020

@garethgreenaway any merge time frame for that PR not that code freeze ended?

Copy link
Member

@cbosdo We're working through some failing tests before starting to merge PRs, hopefully this week.

@sagetherage sagetherage added Bug broken, incorrect, or confusing behavior Magnesium Mg release after Na prior to Al severity-high 2nd top severity, seen by most users, causes major problems labels Jul 22, 2020
@cbosdo
Copy link
Collaborator Author

cbosdo commented Jul 23, 2020

Updated on latest master

The libvirt constants for pool and nodedev events need tweaking since
they don't match the rule used to autogenerate them. Fixes these warnings
at the engine start.

   Skipping "pool/lifecycle" events: libvirt too old
   Skipping "pool/refresh" events: libvirt too old
   Skipping "nodedev/lifecycle" events: libvirt too old
   Skipping "nodedev/update" events: libvirt too old
@cbosdo
Copy link
Collaborator Author

cbosdo commented Jul 31, 2020

Rebased on master and updated the six and py2 code.

@cbosdo
Copy link
Collaborator Author

cbosdo commented Jul 31, 2020

@dwoz could you merge this PR? it's a rather simple fix + the py2/six automated code cleanup.

Akm0d
Akm0d approved these changes Jul 31, 2020
@dwoz dwoz merged commit 392cf89 into saltstack:master Jul 31, 2020
26 checks passed
@cbosdo cbosdo deleted the libvirt-engine-fixes branch August 1, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior has-failing-test Magnesium Mg release after Na prior to Al severity-high 2nd top severity, seen by most users, causes major problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libvirt engine doesn't listen on storage events on recent libvirt
6 participants