modules.postgres: pass waldir to init #57770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 2016.3.0 postgres.datadir_init() takes a 'waldir' keyword argument to specify a location for an external wal directory - but this parameter is not passed to _run_initdb (l. 3596), rendering 'waldir' effectively nonfunctional. The fix is obvious - pass the parameter. The unit test is being modified to at least catch 'waldir' set to None (unset). Testing the generated initdb command line or even final data directory properties would be desirable, but seems to be much more invasive and thus not that suitable for a "small bugfix".
ghost
requested review from
|
do I need to do anything to get this backpatched to older (supported) releases? |
sagetherage
requested review from
garethgreenaway
and removed request for
twangboy
|
Oh cool, I never got the mail with the changes. And whatever that gitlab pipeline is doing. |
garethgreenaway
approved these changes
Jan 14, 2021
Ch3LL
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 2019.2.0 postgres.datadir_init() takes a 'waldir' keyword
argument to specify a location for an external wal directory -
but this parameter is not passed to _run_initdb (l. 3596),
rendering 'waldir' effectively nonfunctional.
The fix is obvious - pass the parameter. The unit test is
being modified to at least catch 'waldir' set to None (unset).
Testing the generated initdb command line or even final data
directory properties would be desirable, but seems to be much
more invasive and thus not that suitable for a "small bugfix".
Fixes: #57769