File state: skip symlink file permissions on linux #57782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we can not change symlink file mode on linux do not check it to not report the difference between real and desired mode as a change.
ghost
requested review from
sagetherage
added
v3001.1
dwoz
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What does this PR do?
Ignore file permissions for symlinks on linux if
follow_symlinksisFalsesince it does not allow permission change.What issues does this PR fix or reference?
Fixes: #55878
Previous Behavior
file.directorystate always reports permission changes on symlinks whenfollow_symlinks = Trueand it is targeted to a symlink or recursively targeted to a directory containing a symlink ifdir_modeis different from0o777. See #55878 for details.New Behavior
file.directoryreports no change when it's not expected.Merge requirements satisfied?
Commits signed with GPG?
Yes