Certutil result #57831
Merged
Certutil result #57831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Currently builds are failing with: Cannot contact EC2 (saltstack-ci) - kitchen |
clarified changelog to clarify it was failing before and no longer won't.
|
Builds are now passing. |
cmcmarrow
approved these changes
Jul 7, 2020
|
@Ifanew thanks for the PR and tests. Your PR is good to be merged. |
|
@cmcmarrow merged latest master commits into branch. Tests passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for getting retcode instead of out from win_certutil module. It also changes win_certutil state to base success off of the return code vs parsing the out for the English word "success".
What issues does this PR fix or reference?
Fixes: #55024
Previous Behavior
State would return a failed result even though certificate was successfully added to store depending on system's language setting.
New Behavior
The state will now succeed in these cases across these different languages by observing return code rather than output.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No