Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certutil result #57831

Merged
merged 11 commits into from Jul 29, 2020
Merged

Certutil result #57831

merged 11 commits into from Jul 29, 2020

Conversation

lfanew
Copy link
Contributor

@lfanew lfanew commented Jun 28, 2020

What does this PR do?

Add support for getting retcode instead of out from win_certutil module. It also changes win_certutil state to base success off of the return code vs parsing the out for the English word "success".

What issues does this PR fix or reference?

Fixes: #55024

Previous Behavior

State would return a failed result even though certificate was successfully added to store depending on system's language setting.

New Behavior

The state will now succeed in these cases across these different languages by observing return code rather than output.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

@lfanew lfanew marked this pull request as ready for review June 29, 2020 02:22
@lfanew lfanew requested a review from a team as a code owner June 29, 2020 02:22
@ghost ghost requested review from cmcmarrow and removed request for a team June 29, 2020 02:22
@lfanew
Copy link
Contributor Author

lfanew commented Jun 29, 2020

Currently builds are failing with:

Cannot contact EC2 (saltstack-ci) - kitchen

lfanew and others added 3 commits June 29, 2020 12:57
@lfanew
Copy link
Contributor Author

lfanew commented Jun 30, 2020

Builds are now passing.

@cmcmarrow
Copy link
Contributor

@Ifanew thanks for the PR and tests. Your PR is good to be merged.

@lfanew
Copy link
Contributor Author

lfanew commented Jul 17, 2020

@cmcmarrow merged latest master commits into branch. Tests passing.

@dwoz dwoz merged commit d5cbbfd into saltstack:master Jul 29, 2020
26 checks passed
@sagetherage sagetherage added the Magnesium Mg release after Na prior to Al label Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Magnesium Mg release after Na prior to Al
Projects
None yet
Development

Successfully merging this pull request may close these issues.

salt.states.win_certutil wrong result
5 participants