Start upgrading codebase to Py3 for every changed file#57936
Merged
Conversation
s0undt3ch
force-pushed
the
features/pyupgrade
branch
from
July 14, 2020 09:19
45220bd to
77bcc3a
Compare
Contributor
Author
|
The pipeline changes worked, see https://jenkinsci.saltstack.com/job/pr-pre-commit/job/PR-57936/1/console |
Contributor
Author
|
This PR only "works" as expected once https://github.com/saltstack/salt-jenkins-pipeline-libs/pull/33 is merged |
s0undt3ch
force-pushed
the
features/pyupgrade
branch
5 times, most recently
from
July 16, 2020 12:59
e4e2d65 to
288727b
Compare
3 tasks
s0undt3ch
marked this pull request as ready for review
July 27, 2020 06:28
s0undt3ch
force-pushed
the
features/pyupgrade
branch
from
July 27, 2020 06:32
288727b to
7d912e2
Compare
dwoz
added
the
needs-testcase
waynew
approved these changes
Jul 27, 2020
waynew
left a comment
waynew
left a comment
Contributor
There was a problem hiding this comment.
Does this mean that everyone who submits code will be running pyupgrade as part of their PR?
Contributor
Author
|
If they have pre-commit configured, yes, for the files they change, only those. |
s0undt3ch
removed
the
needs-testcase
Contributor
Author
|
To the whole codebase. |
waynew
approved these changes
Jul 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Starts upgrading the codebase to Py3 for every changed file by running
pyupgradeagainst it.We only do this for each changed file and not the whole code base to avoid MASSIVE code churn.