Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start upgrading codebase to Py3 for every changed file #57936

Merged
merged 2 commits into from
Jul 28, 2020
Merged

Start upgrading codebase to Py3 for every changed file #57936

merged 2 commits into from
Jul 28, 2020

Conversation

s0undt3ch
Copy link
Collaborator

What does this PR do?

Starts upgrading the codebase to Py3 for every changed file by running pyupgrade against it.
We only do this for each changed file and not the whole code base to avoid MASSIVE code churn.

@s0undt3ch s0undt3ch added the Magnesium Mg release after Na prior to Al label Jul 14, 2020
@s0undt3ch s0undt3ch force-pushed the features/pyupgrade branch from 45220bd to 77bcc3a Compare July 14, 2020 09:19
@s0undt3ch
Copy link
Collaborator Author

The pipeline changes worked, see https://jenkinsci.saltstack.com/job/pr-pre-commit/job/PR-57936/1/console

@s0undt3ch s0undt3ch mentioned this pull request Jul 14, 2020
Merged
@s0undt3ch
Copy link
Collaborator Author

This PR only "works" as expected once saltstack/salt-jenkins-pipeline-libs#33 is merged

@s0undt3ch s0undt3ch force-pushed the features/pyupgrade branch 5 times, most recently from e4e2d65 to 288727b Compare July 16, 2020 12:59
@s0undt3ch s0undt3ch mentioned this pull request Jul 17, 2020
Closed
3 tasks
@s0undt3ch s0undt3ch marked this pull request as ready for review July 27, 2020 06:28
@s0undt3ch s0undt3ch requested a review from a team as a code owner July 27, 2020 06:28
@ghost ghost requested review from Akm0d and removed request for a team July 27, 2020 06:28
@s0undt3ch s0undt3ch force-pushed the features/pyupgrade branch from 288727b to 7d912e2 Compare July 27, 2020 06:32
@dwoz dwoz added the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Jul 27, 2020
waynew
waynew approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that everyone who submits code will be running pyupgrade as part of their PR?

@s0undt3ch
Copy link
Collaborator Author

If they have pre-commit configured, yes, for the files they change, only those.
It's either that or we do it ourselves in one go.

@s0undt3ch s0undt3ch removed the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Jul 28, 2020
@s0undt3ch
Copy link
Collaborator Author

To the whole codebase.

@dwoz dwoz merged commit cf391a2 into saltstack:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynew waynew waynew approved these changes

@Akm0d Akm0d Awaiting requested review from Akm0d

Assignees
No one assigned
Labels
Magnesium Mg release after Na prior to Al
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@s0undt3ch @waynew @dwoz @krionbsd