Fix bugs with macOS and Windows services. - #57942
Merged
Merged
Conversation
noelmcloughlin
previously approved these changes
Jul 15, 2020
noelmcloughlin
left a comment
noelmcloughlin
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just some quick eyes.
sheagcraig
reviewed
Jul 15, 2020
sagetherage
added
bug
Contributor
|
re-run full all |
Contributor
Author
|
re-run full all |
Akm0d
approved these changes
Aug 19, 2020
dwoz
approved these changes
Aug 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes multiple issues with macOS and Windows services.
What issues does this PR fix or reference?
Fixes: #57908
Fixes #57907
Fixes #49237
Previous Behavior
salt would get really sad when trying to start some services on macOS and Windows.
New Behavior
They work as intended... 😄
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes