Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs with macOS and Windows services. #57942

Merged
merged 32 commits into from Aug 24, 2020

Conversation

weswhet
Copy link
Collaborator

@weswhet weswhet commented Jul 14, 2020

What does this PR do?

Fixes multiple issues with macOS and Windows services.

What issues does this PR fix or reference?

Fixes: #57908
Fixes #57907
Fixes #49237

Previous Behavior

salt would get really sad when trying to start some services on macOS and Windows.

New Behavior

They work as intended... 馃槃

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@weswhet weswhet requested a review from a team as a code owner July 14, 2020 23:37
@ghost ghost requested review from Akm0d and removed request for a team July 14, 2020 23:37
noelmcloughlin
noelmcloughlin previously approved these changes Jul 15, 2020
Copy link
Contributor

@noelmcloughlin noelmcloughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some quick eyes.

@sagetherage sagetherage requested a review from dwoz July 16, 2020 01:48
@sagetherage sagetherage added Bug broken, incorrect, or confusing behavior MacOS pertains to the OS of fruit Magnesium Mg release after Na prior to Al Windows labels Jul 16, 2020
@Akm0d
Copy link
Contributor

Akm0d commented Jul 17, 2020

re-run full all

@weswhet
Copy link
Collaborator Author

weswhet commented Aug 15, 2020

re-run full all

Akm0d
Akm0d approved these changes Aug 19, 2020
dwoz
dwoz approved these changes Aug 24, 2020
@dwoz dwoz merged commit e18f569 into saltstack:master Aug 24, 2020
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior MacOS pertains to the OS of fruit Magnesium Mg release after Na prior to Al Windows
Projects
None yet
6 participants