Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor virt.migrate #57947

Merged
merged 35 commits into from
Aug 24, 2020
Merged

Refactor virt.migrate #57947

merged 35 commits into from
Aug 24, 2020

Conversation

rst0git
Copy link
Contributor

@rst0git rst0git commented Jul 15, 2020 •
edited
Loading

This PR is rebased on #57736, which provides integration tests for live migration.

What does this PR do?

This PR modifies the existing virt.migrate functionality to use the Python bindings of libvirt instead of the virsh command-line tool. This approach allows to make of the libvirt migration options available to users via a generic interface that doesn't require an increased number functions. Although backwards comparability is preserved, the ssh parameter of virt.migrate, virt.migrate_non_shared and virt.migrate_non_shared_inc have been marked as deprecated.

Previous Behavior

salt src virt.migrate guest dst True
salt src virt.migrate_non_shared guest dst True
salt src virt.migrate_non_shared_inc guest-vm dst True

New Behavior

salt src virt.migrate guest dst True
salt src virt.migrate_non_shared guest dst True
salt src virt.migrate_non_shared_inc guest-vm dst True

salt src virt.migrate guest qemu+ssh://dst/system
salt src virt.migrate guest qemu+tcp://dst/system
salt src virt.migrate guest qemu+tls://dst/system
salt src virt.migrate guest qemu+tls://dst/system copy_storage=all
salt src virt.migrate guest qemu+tls://dst/system copy_storage=incremental

Merge requirements satisfied?

@rst0git rst0git requested a review from a team as a code owner July 15, 2020 09:21
@ghost ghost requested review from cmcmarrow and removed request for a team July 15, 2020 09:21
@rst0git rst0git force-pushed the virt-live-migration branch from 0f12ac4 to f4001be Compare July 15, 2020 09:22
@rst0git
Copy link
Contributor Author

rst0git commented Jul 15, 2020

cc: @cbosdo

@rst0git rst0git force-pushed the virt-live-migration branch from f4001be to 8bca922 Compare July 15, 2020 10:01
@cmcmarrow
Copy link
Contributor

@rst0git thanks for the PR and tests! Once I look over the PR and give it the green light this should be merge ready and will probably make it into Magnesium.

cmcmarrow
cmcmarrow previously approved these changes Jul 15, 2020
View reviewed changes
@rst0git rst0git force-pushed the virt-live-migration branch from 8bca922 to 3cc45c6 Compare July 16, 2020 07:04
@rst0git
Copy link
Contributor Author

rst0git commented Jul 16, 2020

@cmcmarrow Thank you for the review! I rebased the PR on master and added two commits with changelog information.

@rst0git rst0git requested a review from cmcmarrow July 16, 2020 07:09
@rst0git rst0git force-pushed the virt-live-migration branch from 3cc45c6 to fef84c1 Compare July 16, 2020 07:26
@rst0git rst0git force-pushed the virt-live-migration branch from fef84c1 to 5f9008e Compare July 16, 2020 07:37
@rst0git rst0git mentioned this pull request Jul 16, 2020
Closed
cmcmarrow
cmcmarrow previously approved these changes Jul 16, 2020
View reviewed changes
@s0undt3ch
Copy link
Collaborator

Please do not merge this PR, it's blocked on external changes happening first.
Please read #57897 (comment) for context.

I will reply once the issues have been resolved to unblock this PR.

rst0git added a commit to rst0git/salt that referenced this pull request Jul 29, 2020
@rst0git
Add changelog for saltstack#57947
3a55f9e 
Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
@rst0git rst0git force-pushed the virt-live-migration branch 2 times, most recently from a69df7b to 5ff8d12 Compare August 19, 2020 08:20
rst0git added 8 commits August 21, 2020 12:47
@rst0git
virt: Add support for migration bandwidth limit
1554490 
Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
@rst0git
virt.migrate: Add live/persistent/undefinesource options
cfec159 
Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
@rst0git
virt.migrate: Add support for max_downtime
c1b3818 
Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
@rst0git
virt.migrate: Add support for parallel connections
5e5dad6 
Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
@rst0git
virt.migrate: Add support for compression
23d06b9 
libvirt allows the use of compression with live migration. There are
two compression methods currently supported: "mt" and "xbzrle".

This patch allows extends the virt.migrate function with additional set
of options that allow to enable and configure the compression
functionality of libvirt.

Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
@rst0git
virt.migrate: Initial support for post-copy migration
36b54e7 
Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
@rst0git
Resolve formatting issues
c64ddd4 
Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
@rst0git
virt: Inline copy_storage doc string
3fe7f26 
Without this change generating the docs fails with:
	Block quote ends without a blank line; unexpected unindent.

Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
@rst0git rst0git force-pushed the virt-live-migration branch from 3d4ff72 to a16903e Compare August 21, 2020 11:48
@rst0git rst0git mentioned this pull request Aug 21, 2020
Closed
@s0undt3ch
Copy link
Collaborator

This PR is no longer blocked by the PyTest migration.

s0undt3ch
s0undt3ch suggested changes Aug 21, 2020
View reviewed changes
Copy link
Collaborator

@s0undt3ch s0undt3ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to revert the fixtures. Could you please remove them?

s0undt3ch
s0undt3ch suggested changes Aug 21, 2020
View reviewed changes
Copy link
Collaborator

@s0undt3ch s0undt3ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, left some more debug code around....

@rst0git rst0git force-pushed the virt-live-migration branch 3 times, most recently from 3ce4c97 to 66b4196 Compare August 21, 2020 20:02
@rst0git rst0git requested a review from s0undt3ch August 21, 2020 20:14
s0undt3ch
s0undt3ch previously approved these changes Aug 21, 2020
View reviewed changes
@s0undt3ch s0undt3ch force-pushed the virt-live-migration branch from 66b4196 to a5b0314 Compare August 24, 2020 14:47
@dwoz dwoz merged commit 7580b45 into saltstack:master Aug 24, 2020
dwoz pushed a commit that referenced this pull request Aug 24, 2020
@rst0git @dwoz
Add changelog for #57947
266b5ab 
Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
@sagetherage sagetherage added the Magnesium Mg release after Na prior to Al label Sep 14, 2020
@rst0git rst0git mentioned this pull request Nov 4, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwoz dwoz dwoz approved these changes

@s0undt3ch s0undt3ch s0undt3ch left review comments

@cmcmarrow cmcmarrow cmcmarrow left review comments

Assignees
No one assigned
Labels
Magnesium Mg release after Na prior to Al
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rst0git @cmcmarrow @s0undt3ch @dwoz @sagetherage