Skip to content

Sub state return - #57993

Merged
dwoz merged 6 commits into
saltstack:masterfrom
Akm0d:sub_state_return
Oct 7, 2020
Merged

Sub state return#57993
dwoz merged 6 commits into
saltstack:masterfrom
Akm0d:sub_state_return

Conversation

@Akm0d

@Akm0d Akm0d commented Jul 21, 2020

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds the ability for states to have sub state returns. For example, if you are running a state that runs several external states under a different engine, you can now add those external state runs individually to the "sub_state_run" key of the state return. They will be parsed and printed alongside the salt state runs.

Commits signed with GPG?

Yes

@Akm0d Akm0d added the Feature new functionality including changes to functionality and code refactors, etc. label Jul 21, 2020
@Akm0d
Akm0d requested a review from a team as a code owner July 21, 2020 02:29
@ghost
ghost requested review from krionbsd and removed request for a team July 21, 2020 02:29
@Akm0d Akm0d mentioned this pull request Jul 21, 2020
3 tasks
krionbsd
krionbsd previously approved these changes Jul 23, 2020
@krionbsd krionbsd added this to the Approved milestone Jul 23, 2020
@krionbsd krionbsd added the Magnesium Mg release after Na prior to Al label Jul 23, 2020
Comment thread salt/state.py Outdated
Comment thread tests/unit/test_state.py Outdated
Comment thread tests/unit/test_state.py Outdated
Comment thread doc/ref/states/writing.rst Outdated
@Akm0d Akm0d changed the title Sub state return [WIP] Sub state return Jul 23, 2020
@Akm0d Akm0d changed the title [WIP] Sub state return Sub state return Jul 24, 2020
@Akm0d
Akm0d force-pushed the sub_state_return branch from f4fd777 to 4c67e61 Compare July 24, 2020 07:01
@Akm0d
Akm0d requested review from krionbsd and waynew July 24, 2020 08:40
krionbsd
krionbsd previously approved these changes Jul 24, 2020
thatch45
thatch45 previously approved these changes Jul 27, 2020
@waynew

waynew commented Aug 31, 2020

Copy link
Copy Markdown
Contributor

@Akm0d looks like this one needs pre-commit hooks

@waynew

waynew commented Aug 31, 2020

Copy link
Copy Markdown
Contributor

Also waiting on saltstack/salt-enhancement-proposals#32

@dwoz
dwoz merged commit cfca39c into saltstack:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature new functionality including changes to functionality and code refactors, etc. Magnesium Mg release after Na prior to Al

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants