Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub state return #57993

Merged
merged 6 commits into from Oct 7, 2020
Merged

Sub state return #57993

merged 6 commits into from Oct 7, 2020

Conversation

Akm0d
Copy link
Contributor

@Akm0d Akm0d commented Jul 21, 2020

What does this PR do?

Adds the ability for states to have sub state returns. For example, if you are running a state that runs several external states under a different engine, you can now add those external state runs individually to the "sub_state_run" key of the state return. They will be parsed and printed alongside the salt state runs.

Commits signed with GPG?

Yes

@Akm0d Akm0d added the Feature new functionality including changes to functionality and code refactors, etc. label Jul 21, 2020
@Akm0d Akm0d requested a review from a team as a code owner July 21, 2020 02:29
@ghost ghost requested review from krionbsd and removed request for a team July 21, 2020 02:29
Akm0d added a commit to Akm0d/salt that referenced this pull request Jul 21, 2020
@Akm0d Akm0d mentioned this pull request Jul 21, 2020
3 tasks
krionbsd
krionbsd previously approved these changes Jul 23, 2020
@krionbsd krionbsd added this to the Approved milestone Jul 23, 2020
@krionbsd krionbsd added the Magnesium Mg release after Na prior to Al label Jul 23, 2020
salt/state.py Show resolved Hide resolved
tests/unit/test_state.py Show resolved Hide resolved
tests/unit/test_state.py Show resolved Hide resolved
doc/ref/states/writing.rst Outdated Show resolved Hide resolved
@Akm0d Akm0d changed the title Sub state return [WIP] Sub state return Jul 23, 2020
@Akm0d Akm0d changed the title [WIP] Sub state return Sub state return Jul 24, 2020
krionbsd
krionbsd previously approved these changes Jul 24, 2020
thatch45
thatch45 previously approved these changes Jul 27, 2020
@waynew
Copy link
Contributor

waynew commented Aug 31, 2020

@Akm0d looks like this one needs pre-commit hooks

@waynew
Copy link
Contributor

waynew commented Aug 31, 2020

Also waiting on saltstack/salt-enhancement-proposals#32

Ch3LL
Ch3LL approved these changes Oct 6, 2020
@dwoz dwoz merged commit cfca39c into saltstack:master Oct 7, 2020
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature new functionality including changes to functionality and code refactors, etc. Magnesium Mg release after Na prior to Al
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants