Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#58033 file.read return binary data in binary mode #58034

Merged
merged 2 commits into from Oct 5, 2020

Conversation

jfindlay
Copy link
Contributor

What does this PR do?

Return binary data in binary mode from file.read function.

What issues does this PR fix or reference?

Fixes: #58033

Previous Behavior

See issue description.

New Behavior

See issue description.

Merge requirements satisfied?

Commits signed with GPG?

Yes

@jfindlay jfindlay requested a review from a team as a code owner July 27, 2020 22:03
@ghost ghost requested review from dwoz and removed request for a team July 27, 2020 22:03
@jfindlay jfindlay force-pushed the 58033/return-binary branch 3 times, most recently from 4945db9 to cbc92d9 Compare July 28, 2020 01:14
@sagetherage sagetherage added Bug broken, incorrect, or confusing behavior Confirmed Salt engineer has confirmed bug/feature - often including a MCVE Magnesium Mg release after Na prior to Al severity-high 2nd top severity, seen by most users, causes major problems labels Jul 28, 2020
@dwoz dwoz merged commit d4e2a00 into saltstack:master Oct 5, 2020
26 checks passed
@jfindlay jfindlay deleted the 58033/return-binary branch January 4, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior Confirmed Salt engineer has confirmed bug/feature - often including a MCVE Magnesium Mg release after Na prior to Al severity-high 2nd top severity, seen by most users, causes major problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] file.read exec module function fails on binary data
4 participants