#58033 file.read return binary data in binary mode#58034
Merged
dwoz merged 2 commits intosaltstack:masterfrom Oct 5, 2020
Merged
#58033 file.read return binary data in binary mode#58034dwoz merged 2 commits intosaltstack:masterfrom
file.read return binary data in binary mode#58034dwoz merged 2 commits intosaltstack:masterfrom
Conversation
ghost
requested review from
jfindlay
force-pushed
the
58033/return-binary
branch
3 times, most recently
from
4945db9 to
cbc92d9
Compare
sagetherage
added
bug
jfindlay
force-pushed
the
58033/return-binary
branch
from
cbc92d9 to
113144a
Compare
jfindlay
force-pushed
the
58033/return-binary
branch
from
113144a to
e978f26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Return binary data in binary mode from
file.readfunction.What issues does this PR fix or reference?
Fixes: #58033
Previous Behavior
See issue description.
New Behavior
See issue description.
Merge requirements satisfied?
Commits signed with GPG?
Yes