Port #49063 to master #58042
Merged
Port #49063 to master #58042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
waynew
reviewed
Jul 28, 2020
waynew
reviewed
Jul 28, 2020
Akm0d
previously approved these changes
Jul 28, 2020
waynew
suggested changes
Jul 28, 2020
|
@waynew unfortunately, that message would be misleading. the main reason for the original PR has since been merged for a while... I basically just ported over some additional housekeeping that got left behind. after all that, the main thing that's been added was tests... |
|
Well, it does have the |
|
|
waynew
approved these changes
Jul 28, 2020
sagetherage
added this to PR needs merge to master
in PRs to port to master
via automation
sagetherage
moved this from PR needs merge to master
to PR merged
in PRs to port to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What does this PR do?
Port #49063 to master
What issues does this PR fix or reference?
Fixes: N/A
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.