Repository navigation
[PR port] Port #47835 - Add password support to Redis returner - #58044
Merged
Merged
Conversation
Contributor
|
re-run windows,alma |
Contributor
|
re-run windows |
Contributor
|
re-run centos-7 |
Tests verify that passwords are correctly passed to the underlying StrictRedis function (whos default value for password is None, not an empty string).
In the source for redis, the default value for password is None, not "". If the default is an empty string that may cause some unintended consequences -- though it's entirely possible that Redis does not support empty passwords, it's always safer to match the underlying existing codebase.
dwoz
previously approved these changes
Dec 10, 2023
Contributor
|
@roaldnefs are you able to fix pre-commit please? |
Signed-off-by: Roald Nefs <info@roaldnefs.com>
roaldnefs
force-pushed
the
port-47835
branch
from
December 16, 2023 19:02
580ca8e to
e4d9271
Compare
dwoz
approved these changes
Dec 17, 2023
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR port #47835