Skip to content

[PR port] Port #47835 - Add password support to Redis returner - #58044

Merged
dwoz merged 4 commits into
saltstack:masterfrom
roaldnefs:port-47835
Dec 17, 2023
Merged

dwoz merged 4 commits into
saltstack:masterfrom
roaldnefs:port-47835

Conversation

@roaldnefs

@roaldnefs roaldnefs commented Jul 28, 2020 •

Copy link
Copy Markdown
Contributor

PR port #47835

  • Docs
  • Changelog
  • Tests written/updated

@roaldnefs
roaldnefs requested a review from a team as a code owner July 28, 2020 15:14
@ghost
ghost requested review from garethgreenaway and removed request for a team July 28, 2020 15:14
@dwoz dwoz added the needs-testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Jul 28, 2020
@sagetherage sagetherage added the help-wanted Community help is needed to resolve this label Jul 29, 2020
@waynew waynew removed needs-testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases has-failing-test labels Jun 1, 2021
@waynew

waynew commented Jun 8, 2021

Copy link
Copy Markdown
Contributor

re-run windows,alma

@waynew

waynew commented Jun 8, 2021

Copy link
Copy Markdown
Contributor

re-run windows

@waynew

waynew commented Jun 8, 2021

Copy link
Copy Markdown
Contributor

re-run centos-7

waynew and others added 3 commits December 10, 2023 02:15
Tests verify that passwords are correctly passed to the underlying
StrictRedis function (whos default value for password is None, not an
empty string).
In the source for redis, the default value for password is None, not "".
If the default is an empty string that may cause some unintended
consequences -- though it's entirely possible that Redis does not
support empty passwords, it's always safer to match the underlying
existing codebase.
dwoz
dwoz previously approved these changes Dec 10, 2023
@dwoz

dwoz commented Dec 16, 2023

Copy link
Copy Markdown
Contributor

@roaldnefs are you able to fix pre-commit please?

Signed-off-by: Roald Nefs <info@roaldnefs.com>

This branch was previously deployed

1 inactive deployment
ci — e4d92717 Deployed Dec 17, 2023 by dwoz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants