Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[port jam] 49227 - add ability to pass exclude kwarg to salt.state within orchestrate #58062

Merged
merged 3 commits into from Aug 24, 2021
Merged

[port jam] 49227 - add ability to pass exclude kwarg to salt.state within orchestrate #58062

merged 3 commits into from Aug 24, 2021

Conversation

waynew
Copy link
Contributor

@waynew waynew commented Jul 28, 2020 •
edited by sagetherage

What does this PR do?

Port #49227
and
Closes #58547

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@waynew waynew requested a review from a team as a code owner July 28, 2020 22:26
@ghost ghost requested review from dwoz and removed request for a team July 28, 2020 22:26
@dwoz dwoz added the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Jul 28, 2020
@md-magenta md-magenta mentioned this pull request Sep 22, 2020
Closed
@md-magenta
Copy link
Contributor

@dwoz What is needed for this to be merged? It has a testcase and the failing test seems to just be a fluke.

@md-magenta
Copy link
Contributor

@dwoz and @waynew Is there anything I can do to help further this along?

@sagetherage sagetherage linked an issue Dec 15, 2020 that may be closed by this pull request
There no way to exclude SLS in calling salt.state inside orchestration #49130
Closed
@sagetherage sagetherage added Aluminium Release Post Mg and Pre Si and removed Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases labels Dec 15, 2020
@Ch3LL
Copy link
Contributor

Ch3LL commented Feb 4, 2021

pre-commit needs to be cleaned up here

@sagetherage sagetherage added this to PR needs merge to master in PRs to port to master via automation Feb 8, 2021
@sagetherage
Copy link
Contributor

looks like this is failing on macos catalina and ubuntu 16 04

@sagetherage sagetherage added Silicon v3004.0 Release code name and removed Aluminium Release Post Mg and Pre Si labels Mar 3, 2021
@Ch3LL Ch3LL merged commit d28ff4f into saltstack:master Aug 24, 2021
PRs to port to master automation moved this from PR needs merge to master to PR merged Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ch3LL Ch3LL Ch3LL approved these changes

@dwoz dwoz Awaiting requested review from dwoz

Assignees
No one assigned
Labels
master-port Silicon v3004.0 Release code name
Projects
PRs to port to master
  
PR merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There no way to exclude SLS in calling salt.state inside orchestration
6 participants
@waynew @md-magenta @Ch3LL @sagetherage @dwoz @vryzhenkin