Disable tests on FreeBSD - #58088
Conversation
|
Why do we want to disable these tests on FreeBSD? Are they just irrelevant on that platform? |
|
@waynew exactly, inotify/watchdog have very limited support on FreeBSD at this moment. I temporary disabled 2 shell tests as FreeBSD uses csh as root shell. |
waynew
left a comment
waynew
left a comment
There was a problem hiding this comment.
Should we change the message to indicate that? Like"Skip on FreeBSD - does not yet have inotify/watchdog support"?
|
@waynew that's a bit complicated, FreeBSD has kind of limited inotify support, it doesn't support working with symlinks, as well as directory notifications with |
waynew
left a comment
waynew
left a comment
There was a problem hiding this comment.
👍 looks great, thanks!
I like to have a minimum, but complete amount of information available - that way when future Wayne/Kirill comes looking into these tests after we've learned that there's good inotify support on FreeBSD that we can say, "Oh! We need to re-enable these tests!"
Otherwise we just assume that they need to be skipped forever, or have to dig into why the heck we skipped them in the first place 🙃
4 participants
What does this PR do?
Disable tests on FreeBSD