Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable tests on FreeBSD #58088

Merged
merged 2 commits into from Aug 3, 2020
Merged

Disable tests on FreeBSD #58088

merged 2 commits into from Aug 3, 2020

Conversation

krionbsd
Copy link
Contributor

What does this PR do?

Disable tests on FreeBSD

@krionbsd krionbsd requested a review from a team as a code owner July 30, 2020 07:41
@ghost ghost requested review from waynew and removed request for a team July 30, 2020 07:41
@waynew
Copy link
Contributor

waynew commented Jul 31, 2020

Why do we want to disable these tests on FreeBSD? Are they just irrelevant on that platform?

@krionbsd
Copy link
Contributor Author

krionbsd commented Aug 1, 2020 •
edited

@waynew exactly, inotify/watchdog have very limited support on FreeBSD at this moment. I temporary disabled 2 shell tests as FreeBSD uses csh as root shell.

waynew
waynew suggested changes Aug 3, 2020
View changes
Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change the message to indicate that? Like"Skip on FreeBSD - does not yet have inotify/watchdog support"?

@krionbsd
Copy link
Contributor Author

krionbsd commented Aug 3, 2020

@waynew that's a bit complicated, FreeBSD has kind of limited inotify support, it doesn't support working with symlinks, as well as directory notifications with IN_MOVED_FROM / IN_MOVED_TO, and some open/close notifications like IN_OPEN / IN_CLOSE_NOWRITE. Maybe the skipif like Skip on FreeBSD - does not yet have full inotify/watchdog support ?

waynew
waynew approved these changes Aug 3, 2020
View changes
Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks great, thanks!

I like to have a minimum, but complete amount of information available - that way when future Wayne/Kirill comes looking into these tests after we've learned that there's good inotify support on FreeBSD that we can say, "Oh! We need to re-enable these tests!"

Otherwise we just assume that they need to be skipped forever, or have to dig into why the heck we skipped them in the first place 🙃

@dwoz dwoz merged commit 866840e into saltstack:master Aug 3, 2020
26 checks passed
@sagetherage sagetherage added the Magnesium Mg release after Na prior to Al label Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynew waynew

Assignees
No one assigned
Labels
Magnesium Mg release after Na prior to Al
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@krionbsd @waynew @dwoz @sagetherage