New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linode apiv4 support #58093
Linode apiv4 support #58093
Conversation
re-run ubuntu |
re-run windows |
re-run docs |
d085cbe
to
78b99a6
Compare
5c68864
to
045b242
Compare
045b242
to
9aa87ec
Compare
@dwoz, @garethgreenaway, @twangboy Can you take another look when you get a sec The lint stage is failing because of unrelated changes, but all tests are passing now. |
We should actually run this against the cloudtests, doing that here: #58248 The links are wierd because github records statuses by commit, rather than commit on a pr. |
Also, all of the class docs show up in the html docs which makes them not too pretty. I think there's a flag in sphinx to hide them, but I can't remember what it is. |
no linode cloud test failures, so we're good there.
which is the same as the master branch currently. |
something like
should fix up the docs |
@bryceml all fixed! |
@Akm0d @sagetherage @bryceml Anything I can do to get this merged? |
I believe we have been working to fix test failures (outside of this PR) before merging new code, so it seems we are delayed or forgetful, however the team is focused on fixing test suite issues so merging is smoother in the near future. That being said, I will see about this today and early next week to get it merged. Thank you for the mention! |
Thanks, everyone for getting this merged in!! |
What does this PR do?
This PR adds opt-in Linode APIv4 support to the Linode cloud module via the
api_version
cloud configuration parameter.What issues does this PR fix or reference?
Fixes: #56319
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.