Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR port] Port #54067 - Adding accept_ra 2 option to modules.debian_ip #58097

Merged
merged 4 commits into from
Aug 24, 2020

Conversation

barneysowood
Copy link
Contributor

PR port #
- [ ] Docs
- [X] Changelog
- [X] Tests written/updated

@barneysowood barneysowood requested a review from a team as a code owner July 30, 2020 15:46
@ghost ghost requested review from DmitryKuzmenko and removed request for a team July 30, 2020 15:46
@DmitryKuzmenko
Copy link
Contributor

@barneysowood could you please re-run pre-commit hook on your code and commit the changes?

20:13:13  Drop six usage and Py2 support...........................................Failed
20:13:13  - hook id: pyupgrade
20:13:13  - exit code: 1
20:13:13  - files were modified by this hook
20:13:13  
20:13:13  Rewriting tests/unit/modules/test_debian_ip.py

Natrinicle and others added 4 commits August 17, 2020 21:01
Had to undo the replace all underscores with dashes in the debian_eth
template as that messes up accept_ra which needs to be an underscore
to work.

Added a Unittest as "eth20" for testing accept_ra and autoconf 1 in
IPv6 interfaces.
Currently, the Debian IP module only allows 0 or 1 but 2 is a valid
and sometimes required option.

```
accept_ra - INTEGER
	Accept Router Advertisements; autoconfigure using them.

	It also determines whether or not to transmit Router
	Solicitations. If and only if the functional setting is to
	accept Router Advertisements, Router Solicitations will be
	transmitted.

	Possible values are:
		0 Do not accept Router Advertisements.
		1 Accept Router Advertisements if forwarding is disabled.
		2 Overrule forwarding behaviour. Accept Router Advertisements
		  even if forwarding is enabled.

	Functional default: enabled if local forwarding is disabled.
			    disabled if local forwarding is enabled.
```
https://www.kernel.org/doc/Documentation/networking/ip-sysctl.txt
@barneysowood
Copy link
Contributor Author

@barneysowood could you please re-run pre-commit hook on your code and commit the changes?

@DmitryKuzmenko - done!

@dwoz dwoz merged commit 388f6ef into saltstack:master Aug 24, 2020
@sagetherage sagetherage added the Magnesium Mg release after Na prior to Al label Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Magnesium Mg release after Na prior to Al master-port
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants