[PR port] Port #50620 - Allow to use a custom port in Proxmox connection #58103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
dwoz
added
the
Needs-Testcase
Ability to specify a port for the connection to Proxmox, defaults to 8006 if not specified
- Added the test for the custom port feature - Removed duplicated username call in proxmox.py
piterpunk
force-pushed
the
Port_50620_to_master
branch
from
ec3b930 to
ac1bc6b
Compare
|
Added the tests for this PR |
krionbsd
removed
Needs-Testcase
krionbsd
approved these changes
Aug 29, 2020
dwoz
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR port #50620