Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR port] Port #50620 - Allow to use a custom port in Proxmox connection #58103

Merged
merged 5 commits into from Sep 29, 2020

Conversation

piterpunk
Copy link
Collaborator

@piterpunk piterpunk commented Jul 30, 2020

PR port #50620

  • Docs
  • Changelog
  • Tests written/updated

@piterpunk piterpunk requested a review from a team as a code owner July 30, 2020 21:15
@ghost ghost requested review from krionbsd and removed request for a team July 30, 2020 21:16
@dwoz dwoz added the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Jul 30, 2020
mahalel and others added 3 commits August 16, 2020 08:15
Ability to specify a port for the connection to Proxmox,
defaults to 8006 if not specified
- Added the test for the custom port feature
- Removed duplicated username call in proxmox.py
@piterpunk
Copy link
Collaborator Author

Added the tests for this PR

@krionbsd krionbsd removed Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases has-failing-test labels Aug 27, 2020
dwoz
dwoz approved these changes Sep 29, 2020
@dwoz dwoz merged commit 6ad09b8 into saltstack:master Sep 29, 2020
28 checks passed
@piterpunk piterpunk deleted the Port_50620_to_master branch October 8, 2020 22:54
@sagetherage sagetherage added the Magnesium Mg release after Na prior to Al label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Magnesium Mg release after Na prior to Al master-port
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants