Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not lookup reverse dns with salt-ssh #58163

Merged
merged 2 commits into from Aug 24, 2020
Merged

Conversation

Ch3LL
Copy link
Contributor

@Ch3LL Ch3LL commented Aug 10, 2020

What does this PR do?

Salt-SSH was using the reverse DNS for the target. This PR ensures we do not check the reverse DNS and only use the target the user defined.

What issues does this PR fix or reference?

Fixes: #49840

Previous Behavior

salt-ssh target used the reverse DNS

(salt-py3.7)  ch3ll@thecakeisalie  ~/git/salt  ➦ 1e6bc974f7d  salt-ssh root@127.0.0.1 test.ping
localhost:
    True

As you can see we target 127.0.0.1 but it returns localhost as the target name

New Behavior

salt-ssh does not use reverse DNS and uses the target the user sets.

(salt-py3.7)  ch3ll@thecakeisalie  ~/git/salt   ssh_rev_dns  salt-ssh root@127.0.0.1 test.ping
127.0.0.1:
    True

the target stays the same (127.0.0.1)

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@Ch3LL Ch3LL requested a review from a team as a code owner August 10, 2020 14:33
@ghost ghost requested review from waynew and removed request for a team August 10, 2020 14:33
dwoz
dwoz approved these changes Aug 24, 2020
@dwoz dwoz merged commit ed79b66 into saltstack:master Aug 24, 2020
27 checks passed
@sagetherage sagetherage added the Magnesium Mg release after Na prior to Al label Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Magnesium Mg release after Na prior to Al
Projects
None yet
Development

Successfully merging this pull request may close these issues.

salt-ssh always tries to connect to reverse hostname
3 participants