cpu tuning and Iothreads allocation GSoC - #58196
Merged
Merged
Conversation
gqlo
changed the title
gqlo
changed the title
gqlo
force-pushed
the
cpu_tune
branch
2 times, most recently
from
August 19, 2020 07:35
75fcca4 to
664874b
Compare
cbosdo
suggested changes
Aug 24, 2020
cbosdo
left a comment
cbosdo
left a comment
Contributor
There was a problem hiding this comment.
See my comments inline. Also please merge the cputune-related commits into one
gqlo
force-pushed
the
cpu_tune
branch
7 times, most recently
from
August 30, 2020 14:46
e64d146 to
8e0e3a5
Compare
gqlo
force-pushed
the
cpu_tune
branch
2 times, most recently
from
September 1, 2020 23:31
6d2960e to
7321524
Compare
gqlo
marked this pull request as ready for review
September 2, 2020 00:44
gqlo
changed the title
Akm0d
previously approved these changes
Sep 2, 2020
gqlo
force-pushed
the
cpu_tune
branch
2 times, most recently
from
September 7, 2020 14:57
ecaa599 to
10090a0
Compare
cbosdo
suggested changes
Sep 11, 2020
cbosdo
left a comment
cbosdo
left a comment
Contributor
There was a problem hiding this comment.
Left a few comments to address.
cbosdo
reviewed
Oct 29, 2020
cbosdo
left a comment
cbosdo
left a comment
Contributor
There was a problem hiding this comment.
Another round of questions and things to enhance
gqlo
force-pushed
the
cpu_tune
branch
2 times, most recently
from
November 13, 2020 13:14
607d835 to
fe2de9e
Compare
cbosdo
suggested changes
Nov 13, 2020
cbosdo
left a comment
cbosdo
left a comment
Contributor
There was a problem hiding this comment.
Still a Magnesium laying around, but the rest is OK
Add unit tests for _gen_xml() on the recently added memory parameters. Also fixes an issue with an optional attribute.
Introduce mapping structures in order to help reusing the common patterns in the virt._gen_xml() context pre processing.
In XPath the node numbers are counted from 1 rather than 0. Thus /foo/bar[0] is invalid and should be /foo/bar[1]. Since in the change_xml function we are getting the index from python lists in these cases, we need to offset these.
Contributor
Author
|
re-run centos |
Akm0d
approved these changes
Nov 16, 2020
Contributor
|
@dwoz could you please merge this PR? |
This was referenced Nov 23, 2020
This was referenced Dec 1, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Making
IOThreadsallocation available. These are dedicated event loop threads for supported disk devices to perform block I/O requests.Iothreadsparameter specify the number of IOThreads to be assigned to the domain by supported target storage devices.IOThreadscan be pined usingiothreadpinparameter incputunewhich provides details regarding the CPU tunable parameters for the domain.cputunecontains the following parameters:vcpupinemulatorpiniothreadpinsharesperiodquotaglobal_periodglobal_quotaemulator_periodemulator_quotaiothread_periodiothread_quotavcpusched, iothreadsched and emulatorschedcachetunememorytuneDetailed Libvirt domain xml info can be found at iothreads and cpu tuning
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.