New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu tuning and Iothreads allocation GSoC #58196
Conversation
75fcca4
to
664874b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments inline. Also please merge the cputune-related commits into one
e64d146
to
8e0e3a5
Compare
6d2960e
to
7321524
Compare
ecaa599
to
10090a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments to address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another round of questions and things to enhance
607d835
to
fe2de9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still a Magnesium
laying around, but the rest is OK
Add unit tests for _gen_xml() on the recently added memory parameters. Also fixes an issue with an optional attribute.
Introduce mapping structures in order to help reusing the common patterns in the virt._gen_xml() context pre processing.
In XPath the node numbers are counted from 1 rather than 0. Thus /foo/bar[0] is invalid and should be /foo/bar[1]. Since in the change_xml function we are getting the index from python lists in these cases, we need to offset these.
re-run centos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now
@dwoz could you please merge this PR? |
What does this PR do?
Making
IOThreads
allocation available. These are dedicated event loop threads for supported disk devices to perform block I/O requests.Iothreads
parameter specify the number of IOThreads to be assigned to the domain by supported target storage devices.IOThreads
can be pined usingiothreadpin
parameter incputune
which provides details regarding the CPU tunable parameters for the domain.cputune
contains the following parameters:vcpupin
emulatorpin
iothreadpin
shares
period
quota
global_period
global_quota
emulator_period
emulator_quota
iothread_period
iothread_quota
vcpusched, iothreadsched and emulatorsched
cachetune
memorytune
Detailed Libvirt domain xml info can be found at iothreads and cpu tuning
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.