[master] Ensure proxy_config reads proxy specific configuration #58307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
garethgreenaway
force-pushed
the
58146_proxy_specific_configs_not_used
branch
from
58aedda to
92b42f8
Compare
DmitryKuzmenko
approved these changes
Aug 28, 2020
DmitryKuzmenko
suggested changes
Aug 28, 2020
DmitryKuzmenko
previously approved these changes
Aug 28, 2020
DmitryKuzmenko
previously approved these changes
Sep 15, 2020
…ypically found in /etc/salt/proxy.d/minionid/.
garethgreenaway
force-pushed
the
58146_proxy_specific_configs_not_used
branch
from
b3a8889 to
d348988
Compare
This was referenced Oct 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make proxy_config read in the proxy specific configuration which is typically found in /etc/salt/proxy.d/minionid/.
What issues does this PR fix or reference?
Fixes: #58146
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.