fix: Update macOS brew list command for casks#58381
Merged
s0undt3ch merged 5 commits intosaltstack:masterfrom Dec 28, 2020
cdalvaro:update_brew_cask_list_command
Merged
fix: Update macOS brew list command for casks#58381s0undt3ch merged 5 commits intosaltstack:masterfrom cdalvaro:update_brew_cask_list_command
s0undt3ch merged 5 commits intosaltstack:masterfrom
cdalvaro:update_brew_cask_list_command
Conversation
ghost
requested review from
Akm0d
previously approved these changes
Sep 14, 2020
Contributor
|
@cdalvaro Thank you for the PR! Can the merge conflicts be resolved? |
…st_command * github/master: (657 commits) Update botocore to the latest 1.16.26 release Revert "move_dep_from_module_run (#58701)" (#58702) move_dep_from_module_run (#58701) Update 3002.rst Update 3002.rst Update 3002.rst Update 3002.rst Update 3002.rst Update 3002.rst Update Releasenotes 3002 Update Changelog 3002 Update index.rst Update Reference Magnsium Skip tests depending on the `ssl_webserver` fixture if on Py < 3.5.3 Update man-pages to 3002 Update RC Install Instructions Fix rst formatting Refresh README; add SECURITY; update logos Revert "Set the codepage on windows at import time of `salt/utils/parsers.py`" Set the codepage on windows at import time of `salt/utils/parsers.py` ...
Contributor
Author
Done! |
Akm0d
approved these changes
Oct 12, 2020
Contributor
Author
|
After three months being deprecated this has turned into an error: |
cdalvaro
changed the title
s0undt3ch
approved these changes
Dec 22, 2020
Contributor
|
/cc @weswhet |
SMillerDev
approved these changes
Dec 28, 2020
Contributor
SMillerDev
left a comment
SMillerDev
left a comment
There was a problem hiding this comment.
As a brew maintainer, looks good
s0undt3ch
approved these changes
Dec 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
brew cask --listhas been deprecated in favor ofbrew list --cask(Homebrew/brew#8390).This PR changes the command in order to avoid the fallowing warning:
and prevents for future errors when the command could fail.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
DocsCommits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.