Xen virtual machine disk fixes #58400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The libvirt xen driver does not handle disk of 'volume' type. We thus need to convert them into their equivalent using the 'file' or 'block' type (issue saltstack#58333).
In order to avoid code duplication, extend the _get_all_volumes_path() helper function to also provide the volume and pool names.
In some cases like Xen we have to change the volume disks into file or block ones. Show pool/volumes informations in the virt.get_disk if possible.
ghost
requested review from
Akm0d
approved these changes
Sep 12, 2020
|
@dwoz would be good to have this PR in for Magnesium since it fixes a regression from Sodium |
dwoz
approved these changes
Sep 16, 2020
This was referenced Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR converts the disks of
volumetype into their equivalent offileorblocktype for Xen virtual machines since libvirt libxl driver doesn't handle them.In order to help reversing the magic, this PR also shows the disks as
volumetype if the source path matches one of a known volume.The new unit tests have been added as pytests. In order to start migrating the big number of virt modules unit tests, the existing virt tests for the touched code have been converted to pytest too.
What issues does this PR fix or reference?
Fixes: #58333
Previous Behavior
For a Xen VM the following disk was created:
New Behavior
Now it would create something like:
Merge requirements satisfied?
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.