Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Welcome bot #58414

Merged
merged 7 commits into from Sep 15, 2020
Merged

Add Welcome bot #58414

merged 7 commits into from Sep 15, 2020

Conversation

krionbsd
Copy link
Contributor

@krionbsd krionbsd commented Sep 9, 2020

What does this PR do?

Add Welcome bot

@krionbsd krionbsd requested a review from a team as a code owner September 9, 2020 17:34
@ghost ghost requested review from DmitryKuzmenko and removed request for a team September 9, 2020 17:34
@bryceml
Copy link
Contributor

bryceml commented Sep 9, 2020

can we put links to all the resources mentioned?

   Community Wiki
    Salt’s Contributor Guide
    Join our Community Slack
    IRC on Freenode
    SaltStack YouTube channel
    SaltStackInc Twitch channel```

@krionbsd
Copy link
Contributor Author

krionbsd commented Sep 9, 2020

can we put links to all the resources mentioned?

   Community Wiki
    Salt’s Contributor Guide
    Join our Community Slack
    IRC on Freenode
    SaltStack YouTube channel
    SaltStackInc Twitch channel```

yeah, forgot it, done

bryceml
bryceml previously approved these changes Sep 9, 2020
Copy link
Contributor

@ScriptAutomate ScriptAutomate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions on adding links to our Code of Conduct.

I'm also wondering whether we should need anything in here about the Working Groups? New contributors may not know of them. Maybe an additional link like:

- [SaltStack Working Groups](https://github.com/saltstack/community)

Rendering to:

Though, I do think we should review and update the community repository README.md file, along with information about the docs-hub Documentation Working Group.

Tagging @cassandrafaris and @sagetherage for input^

.github/config.yml Outdated Show resolved Hide resolved
.github/config.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@DmitryKuzmenko DmitryKuzmenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably it'd be good to add a direct link to Cassandra's profile in SaltCommunity Slack. But what Slack gives to me https://saltstackcommunity.slack.com/team/UQP614KNG doesn't work in my environment.

@ScriptAutomate
Copy link
Contributor

Probably it'd be good to add a direct link to Cassandra's profile in SaltCommunity Slack. But what Slack gives to me https://saltstackcommunity.slack.com/team/UQP614KNG doesn't work in my environment.

The link to her profile properly opens when I open that link in Slack, for me.

@sagetherage sagetherage added the Magnesium Mg release after Na prior to Al label Sep 11, 2020
@sagetherage
Copy link
Contributor

Some suggestions on adding links to our Code of Conduct.

I'm also wondering whether we should need anything in here about the Working Groups? New contributors may not know of them. Maybe an additional link like:

- [SaltStack Working Groups](https://github.com/saltstack/community)

Rendering to:

* [SaltStack Working Groups](https://github.com/saltstack/community)

Though, I do think we should review and update the community repository README.md file, along with information about the docs-hub Documentation Working Group.

Tagging @cassandrafaris and @sagetherage for input^

That is fine, those can be separate PRs in those repositories, correct? I can create issues for work to be done, but I cannot do that work this week, perhaps in 2 or 3 weeks.

@krionbsd
Copy link
Contributor Author

https://saltstackcommunity.slack.com/team/UQP614KNG

doesn't work for me in browser, I think providing the email makes more sense though, as not everyone is ready to join the slack to ask the questions

@krionbsd
Copy link
Contributor Author

re-run full windows

@dwoz dwoz merged commit c798380 into saltstack:master Sep 15, 2020
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Magnesium Mg release after Na prior to Al
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants